-
Notifications
You must be signed in to change notification settings - Fork 391
fix(repo): Set @clerk/types as normal dep #3450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 727f01d The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
What's the reason for doing this? |
@desiprisg noticed that when installing a Clerk package that has |
Makes sense 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets add a short description, fix the conflicts and merge :)
@nikosdouvlis Let's proceed with this but the |
This is only partially true. In some instances, yes, the TypeScript types from For example:
Source:
And that uses a type from |
c7a9e52
to
727f01d
Compare
!snapshot |
Hey @desiprisg - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/backend@1.2.2-snapshot.v727f01d --save-exact
npm i @clerk/chrome-extension@1.0.17-snapshot.v727f01d --save-exact
npm i @clerk/clerk-js@5.5.4-snapshot.v727f01d --save-exact
npm i @clerk/elements@0.5.3-snapshot.v727f01d --save-exact
npm i @clerk/clerk-expo@1.1.9-snapshot.v727f01d --save-exact
npm i @clerk/express@0.0.11-snapshot.v727f01d --save-exact
npm i @clerk/fastify@1.0.13-snapshot.v727f01d --save-exact
npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact
npm i @clerk/localizations@2.4.4-snapshot.v727f01d --save-exact
npm i @clerk/nextjs@5.1.4-snapshot.v727f01d --save-exact
npm i @clerk/clerk-react@5.2.3-snapshot.v727f01d --save-exact
npm i @clerk/remix@4.0.14-snapshot.v727f01d --save-exact
npm i @clerk/clerk-sdk-node@5.0.10-snapshot.v727f01d --save-exact
npm i @clerk/shared@2.2.2-snapshot.v727f01d --save-exact
npm i @clerk/testing@1.1.6-snapshot.v727f01d --save-exact |
Description
When installing a Clerk package that has @clerk/types as a dev dep, the types packages is usually not installed (depending on the package manager/ or the user's setup). I think this should be a normal dependency similar to how "@clerk/shared" is used across the monorepo.
Seems to fix the issue I noticed:

With
latest
:WIth snapshot of this PR:

Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change