-
Notifications
You must be signed in to change notification settings - Fork 392
feat(elements): Initial virtual router #3461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 9b997d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!snapshot |
!snapshot |
Hey @tmilewski - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/chrome-extension@1.0.17-snapshot.vec69ef6 --save-exact
npm i @clerk/clerk-js@5.5.4-snapshot.vec69ef6 --save-exact
npm i @clerk/elements@0.5.3-snapshot.vec69ef6 --save-exact
npm i @clerk/clerk-expo@1.1.9-snapshot.vec69ef6 --save-exact
npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact
npm i @clerk/localizations@2.4.4-snapshot.vec69ef6 --save-exact |
!snapshot |
Hey @tmilewski - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/chrome-extension@1.0.17-snapshot.v3c4cd45 --save-exact
npm i @clerk/clerk-js@5.5.4-snapshot.v3c4cd45 --save-exact
npm i @clerk/elements@0.6.0-snapshot.v3c4cd45 --save-exact
npm i @clerk/clerk-expo@1.1.9-snapshot.v3c4cd45 --save-exact
npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact
npm i @clerk/localizations@2.4.4-snapshot.v3c4cd45 --save-exact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
||
// TODO: eventually we'll rely on the framework SDK to specify its host router, but for now we'll default to Next.js | ||
const router = useNextRouter(); | ||
const router = (routing === ROUTING.virtual ? useVirtualRouter : useNextRouter)(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conditional hook call? 🙅
conditional hook, call 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Fixes SDK-1789
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change