Skip to content

Conversation

tmilewski
Copy link
Member

@tmilewski tmilewski commented May 29, 2024

Description

Fixes SDK-1789

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@tmilewski tmilewski self-assigned this May 29, 2024
Copy link

changeset-bot bot commented May 29, 2024

🦋 Changeset detected

Latest commit: 9b997d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/elements Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tmilewski
Copy link
Member Author

!snapshot

@clerk clerk deleted a comment from clerk-cookie May 29, 2024
@tmilewski
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @tmilewski - the snapshot version command generated the following package versions:

Package Version
@clerk/chrome-extension 1.0.17-snapshot.vec69ef6
@clerk/clerk-js 5.5.4-snapshot.vec69ef6
@clerk/elements 0.5.3-snapshot.vec69ef6
@clerk/clerk-expo 1.1.9-snapshot.vec69ef6
gatsby-plugin-clerk 5.0.0-beta.45
@clerk/localizations 2.4.4-snapshot.vec69ef6

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.17-snapshot.vec69ef6 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.5.4-snapshot.vec69ef6 --save-exact

@clerk/elements

npm i @clerk/elements@0.5.3-snapshot.vec69ef6 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.1.9-snapshot.vec69ef6 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.4-snapshot.vec69ef6 --save-exact

@tmilewski tmilewski marked this pull request as ready for review May 29, 2024 18:33
@tmilewski tmilewski requested a review from brkalow May 29, 2024 18:33
@tmilewski
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @tmilewski - the snapshot version command generated the following package versions:

Package Version
@clerk/chrome-extension 1.0.17-snapshot.v3c4cd45
@clerk/clerk-js 5.5.4-snapshot.v3c4cd45
@clerk/elements 0.6.0-snapshot.v3c4cd45
@clerk/clerk-expo 1.1.9-snapshot.v3c4cd45
gatsby-plugin-clerk 5.0.0-beta.45
@clerk/localizations 2.4.4-snapshot.v3c4cd45

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.17-snapshot.v3c4cd45 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.5.4-snapshot.v3c4cd45 --save-exact

@clerk/elements

npm i @clerk/elements@0.6.0-snapshot.v3c4cd45 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.1.9-snapshot.v3c4cd45 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.4-snapshot.v3c4cd45 --save-exact

Copy link
Member

@brkalow brkalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


// TODO: eventually we'll rely on the framework SDK to specify its host router, but for now we'll default to Next.js
const router = useNextRouter();
const router = (routing === ROUTING.virtual ? useVirtualRouter : useNextRouter)();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conditional hook call? 🙅
conditional hook, call 👌

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahaha

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants