fix: handle ppr error message refactor #3499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b8dfcfa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
approved these changes
Jun 3, 2024
|
Nice work @ceIia 🎉 and thank you for the contribution! |
dimkl
force-pushed
the
fix/react-ppr-bailout
branch
from
bda8e2a to
79cd87a
Compare
|
is there something i can do to fix the failing check @dimkl? i'm not 100% sure of why it broke |
dimkl
force-pushed
the
fix/react-ppr-bailout
branch
from
79cd87a to
69998a6
Compare
|
@ceIia we are facing an issue with the integration tests failing for a PR from a forked repo because the GH secrets are not shared. I will let you know about the progress in the next couple of hours. |
dimkl
force-pushed
the
fix/react-ppr-bailout
branch
from
69998a6 to
4d3a5c1
Compare
nikosdouvlis
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in a pull request introduced last january in next.js (
dynamic-rendering.ts:153), the message passed inReact.unstable_postponethrown for PPR bailout was changed, meaning the check implemented by #2518 was not enough anymore, and the bailout was not being rethrown anymore, breaking next.js builds using ppr, and probably other issues.i've updated it to match the latest version, but kept the old check for the sake of not causing a breaking change.
to test:
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change