fix(clerk-js): Do not distort application logo #3501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8f6b7f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!preview |
|
Hey @LekoArts, your preview is available.
|
alexcarpenter
approved these changes
Jun 3, 2024
|
Isn't this a breaking change? |
|
Depends on how you customize your styles. With default styles, nothing changes. With minor edits, nothing changes. If you overwrote things like width/height, things might change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
object-fitfromlogoBoxobject-fit: containtologoImageso that image is not distorted. Aligns with what https://developer.mozilla.org/en-US/docs/Learn/CSS/Howto/Fill_a_box_with_an_image explainsFixes SDK-1781
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change