fix(clerk-sdk-node): Correctly forward errors to next() if request URL is invalid
#4087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7f5352b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LekoArts
changed the title
next() if request URL is invalid
brkalow
approved these changes
Sep 3, 2024
…are-doesnt-throw-if-provided-with
…are-doesnt-throw-if-provided-with
LekoArts
deleted the
lekoarts/eco-181-ensure-that-express-middleware-doesnt-throw-if-provided-with
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, when you called the middleware with a
reqof let's say//, an error was thrown that crashed the server. Thenew URL(req.url || '', `${protocol}://clerk-dummy`)call is now inside a try/catch so that the error can be passed tonext().Fixes ECO-181
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change