-
Notifications
You must be signed in to change notification settings - Fork 394
fix(ui): Ensure card take up their max available space #4094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alexcarpenter
merged 11 commits into
main
from
alexcarpenter/sdki-641-ensure-card-component-fills-the-max-width-space
Sep 5, 2024
Merged
fix(ui): Ensure card take up their max available space #4094
alexcarpenter
merged 11 commits into
main
from
alexcarpenter/sdki-641-ensure-card-component-fills-the-max-width-space
Sep 5, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 958f897 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…-fills-the-max-width-space
…max-width-space' of github.com:clerk/javascript into alexcarpenter/sdki-641-ensure-card-component-fills-the-max-width-space
…-fills-the-max-width-space
joe-bell
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All working for me! Nice work @alexcarpenter
…-fills-the-max-width-space
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Up until this point each step has a wrapping
div
orform
element that comes from the Elements step component. This caused some width issues with the max width on the card and adds an extra element in the dom that we could merge into the card root component.This PR adds
asChild
props where missing on steps in elements and adds support for anas
prop on the card root component to render as either adiv
orform
element. This allows us to use asChild on the step onto the card root reducing the extra element. Reducing the amount of descriptors needed ultimately.Example:
Fixes SDKI-641
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change