fix(clerk-js): Ensure we do not access addEventListener and dispatchEvent in non-browser environments
#4095
Conversation
…on-browser environments
🦋 Changeset detectedLatest commit: 846c8cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| }; | ||
| } | ||
|
|
||
| export const injectedWeb3Providers = new InjectedWeb3Providers(); |
There was a problem hiding this comment.
Exporting this makes it global (calling the addEventListener and dispatchEvent methods) and errors out in non-browser environments
wobsoriano
changed the title
addEventListener and dispatchEvent in non-browser environments
| } | ||
|
|
||
| export const injectedWeb3Providers = new InjectedWeb3Providers(); | ||
| export const getInjectedWeb3Providers = () => InjectedWeb3Providers.getInstance(); |
There was a problem hiding this comment.
Exporting it now as a function but making sure it's still instantiated once
|
|
||
| constructor() { | ||
| private constructor() { | ||
| if (typeof window === 'undefined') { |
There was a problem hiding this comment.
Odd that this didn't catch it. Does this mean expo is defining window, but not addEventListener? 😵
There was a problem hiding this comment.
React Native is defining window here 🤯
There was a problem hiding this comment.
and looks like expo too
wobsoriano
deleted the
rob/sdk-1922-clerk-expo-is-throwing-typeerror-windowaddeventlistener-is
branch
3 participants
Description
This PR makes sure to NOT call browser specific methods (
addEventListener,dispatchEvent) implemented in 4059 in non-browser environments. Even though we are trying to block calls by checkingwindowobject, it'll still pass because React Native does have some polyfills to thewindowobject.Fixes SDK-1922
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change