Skip to content

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Sep 4, 2024

Description

Improve JSDoc coverage on some <ClerkProvider> properties.
Docs PR: clerk/clerk-docs#1510

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Sep 4, 2024

🦋 Changeset detected

Latest commit: 41fc4dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@clerk/clerk-react Patch
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/elements Patch
@clerk/clerk-expo Patch
@clerk/nextjs Patch
@clerk/remix Patch
@clerk/tanstack-start Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/clerk-js Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/clerk-sdk-node Patch
@clerk/shared Patch
@clerk/testing Patch
@clerk/themes Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

* Define the npm version for `@clerk/clerk-js`
*/
clerkJSVersion?: string;
sdkMetadata?: SDKMetadata;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this since it's defined in ClerkOptions

@LekoArts LekoArts changed the title chore(react): Improve JSDoc coverage on ClerkProvider chore(clerk-react): Improve JSDoc coverage on ClerkProvider Sep 4, 2024
Copy link
Member

@octoper octoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>
@LekoArts LekoArts enabled auto-merge (squash) September 4, 2024 10:24
Copy link
Member

@LauraBeatris LauraBeatris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@LekoArts LekoArts merged commit 8823c21 into main Sep 4, 2024
20 checks passed
@LekoArts LekoArts deleted the make-nikos-happy branch September 4, 2024 12:33
wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants