-
Notifications
You must be signed in to change notification settings - Fork 392
chore(clerk-js, types): Drop top level billing flags from environment #6882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(clerk-js, types): Drop top level billing flags from environment #6882
Conversation
🦋 Changeset detectedLatest commit: 370480a The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughRemoved top-level billing flags (enabled, hasPaidUserPlans, hasPaidOrgPlans) from types, core CommerceSettings, and test fixtures. Updated JSON load/serialize logic accordingly. Added changeset documenting the Billing Beta behavior change and minor bumps for @clerk/clerk-js and @clerk/types. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
Description
Internally clerk-js and our hooks already use the payer specific flags (e.g.
user.enabled
). The react hooks from@clerk/shared
never got to used this old properties, thus compatibility with old versions is assured. We should remove this before the Clerk Billing goes to GA, to ensure that we are not making breaking changes later on.Environment is already considered unstable, thus such a change should be permitted.
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change