-
Notifications
You must be signed in to change notification settings - Fork 390
Revert "feat(backend): Add user_id
field to organizationInvitation.accepted
webhook events"
#6888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
….accepte…" This reverts commit ea2bc26.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Caution Review failedThe pull request is closed. WalkthroughThe diff removes the specialized OrganizationInvitationAcceptedJSON type and the separate OrganizationInvitationAcceptedWebhookEvent. It folds the accepted event into OrganizationInvitationWebhookEvent and updates imports and unions accordingly. A changeset entry related to the user_id field on accepted events is deleted. No runtime logic or control flow changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (3)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts a previous feature that added a user_id
field to organizationInvitation.accepted
webhook events. The revert removes the specialized handling for accepted organization invitations and returns to using the generic organization invitation structure for all invitation-related webhook events.
- Removes the
OrganizationInvitationAcceptedJSON
interface that extended the base invitation with auser_id
field - Consolidates webhook event types to use a single
OrganizationInvitationWebhookEvent
for all invitation events - Removes the changeset documentation for the reverted feature
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/backend/src/api/resources/Webhooks.ts | Removes specialized webhook event type and consolidates invitation events |
packages/backend/src/api/resources/JSON.ts | Removes the extended JSON interface with user_id field |
.changeset/blue-teeth-report.md | Removes changeset documentation for the reverted feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Reverts #6887
Need to add
status = 'accepted'
toOrganizationInvitationAcceptedJSON
interface for congruency.Summary by CodeRabbit
Revert
Refactor