Skip to content

Conversation

alexisintech
Copy link
Member

@alexisintech alexisintech commented Sep 30, 2025

Description

Fixes incorrect links in jsdoc comments

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Documentation

    • Corrected links in subscription and subscription item documentation to point to the appropriate resources.
    • No changes to functionality, APIs, or behavior.
  • Chores

    • Added a changeset entry to track these updates.
    • No user-visible impact.

Copy link

changeset-bot bot commented Sep 30, 2025

🦋 Changeset detected

Latest commit: 31d716a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Sep 30, 2025 9:33pm

Copy link
Contributor

coderabbitai bot commented Sep 30, 2025

Walkthrough

Adds a changeset metadata file and updates documentation links in two backend resource files. No functional code changes or exported API modifications.

Changes

Cohort / File(s) Summary
Documentation link updates
packages/backend/src/api/resources/CommerceSubscription.ts, packages/backend/src/api/resources/CommerceSubscriptionItem.ts
Updated doc comment hyperlinks to correct billing resource references; no code or API changes.
Changeset metadata
.changeset/loud-regions-reply.md
Added a changeset file containing only delimiter lines; no effect on behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I thump my paws—links set aright,
No code to chase, no bugs to bite.
A gentle nibble at docs tonight,
Two paths now gleam with proper light.
Hop! A changeset—quiet, slight.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The pull request title clearly identifies that documentation links in the backend code are being corrected in the JSDoc comments, directly matching the changeset which only updates those references without altering functionality.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch aa/fix-typedoc-links

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2754a77 and 31d716a.

📒 Files selected for processing (3)
  • .changeset/loud-regions-reply.md (1 hunks)
  • packages/backend/src/api/resources/CommerceSubscription.ts (1 hunks)
  • packages/backend/src/api/resources/CommerceSubscriptionItem.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (7)
.changeset/**

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Automated releases must use Changesets.

Files:

  • .changeset/loud-regions-reply.md
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

**/*.{js,jsx,ts,tsx}: All code must pass ESLint checks with the project's configuration
Follow established naming conventions (PascalCase for components, camelCase for variables)
Maintain comprehensive JSDoc comments for public APIs
Use dynamic imports for optional features
All public APIs must be documented with JSDoc
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Profile and optimize critical paths
Validate all inputs and sanitize outputs
Implement proper logging with different levels

Files:

  • packages/backend/src/api/resources/CommerceSubscription.ts
  • packages/backend/src/api/resources/CommerceSubscriptionItem.ts
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • packages/backend/src/api/resources/CommerceSubscription.ts
  • packages/backend/src/api/resources/CommerceSubscriptionItem.ts
packages/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

TypeScript is required for all packages

Files:

  • packages/backend/src/api/resources/CommerceSubscription.ts
  • packages/backend/src/api/resources/CommerceSubscriptionItem.ts
packages/**/*.{ts,tsx,d.ts}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Packages should export TypeScript types alongside runtime code

Files:

  • packages/backend/src/api/resources/CommerceSubscription.ts
  • packages/backend/src/api/resources/CommerceSubscriptionItem.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use proper TypeScript error types

**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoid any type - prefer unknown when type is uncertain, then narrow with type guards
Use interface for object shapes that might be extended
Use type for unions, primitives, and computed types
Prefer readonly properties for immutable data structures
Use private for internal implementation details
Use protected for inheritance hierarchies
Use public explicitly for clarity in public APIs
Prefer readonly for properties that shouldn't change after construction
Prefer composition and interfaces over deep inheritance chains
Use mixins for shared behavior across unrelated classes
Implement dependency injection for loose coupling
Let TypeScript infer when types are obvious
Use const assertions for literal types: as const
Use satisfies operator for type checking without widening
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Use type-only imports: import type { ... } from ...
No any types without justification
Proper error handling with typed errors
Consistent use of readonly for immutable data
Proper generic constraints
No unused type parameters
Proper use of utility types instead of manual type construction
Type-only imports where possible
Proper tree-shaking friendly exports
No circular dependencies
Efficient type computations (avoid deep recursion)

Files:

  • packages/backend/src/api/resources/CommerceSubscription.ts
  • packages/backend/src/api/resources/CommerceSubscriptionItem.ts
**/*.{js,ts,tsx,jsx}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Support multiple Clerk environment variables (CLERK_, NEXT_PUBLIC_CLERK_, etc.) for configuration.

Files:

  • packages/backend/src/api/resources/CommerceSubscription.ts
  • packages/backend/src/api/resources/CommerceSubscriptionItem.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Build Packages
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (2)
packages/backend/src/api/resources/CommerceSubscription.ts (1)

7-7: Doc link correction looks good.

The JSDoc now points at the billing-specific resource doc, matching the class name and usage. Thanks for tightening that up.

packages/backend/src/api/resources/CommerceSubscriptionItem.ts (1)

7-7: Updated reference matches the resource doc.

The comment now targets the billing subscription item doc, which aligns with the type being described. Looks good.

Comment on lines +1 to +2
---
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Fix the malformed changeset front matter.

This changeset only contains the opening/closing --- delimiters, so it’s missing the required front matter (package bumps, semver type, etc.). pnpm changeset status/release automation will fail to parse it. Please add the proper front matter and description.

Apply something like:

----
----
+---
+"@clerk/backend": patch
+---
+
+Fix incorrect doc links in backend subscription resources.

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents
In .changeset/loud-regions-reply.md around lines 1 to 2 the file only contains
the opening/closing --- delimiters and is missing the required YAML front matter
and description; update the file to include proper front matter listing the
packages to bump and their semver types (e.g., releases: - package-name:
<package> type: patch) and add a short Markdown description below the front
matter explaining the change so the changeset can be parsed by pnpm changeset
and release tooling.

Copy link

pkg-pr-new bot commented Sep 30, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6896

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6896

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6896

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6896

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6896

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6896

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6896

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6896

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6896

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6896

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6896

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6896

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6896

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6896

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6896

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6896

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6896

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6896

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6896

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6896

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6896

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6896

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6896

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6896

commit: 31d716a

@alexisintech alexisintech changed the title chore(repo): Fix incorrect links in jsdoc comments docs(backend): Fix incorrect links in jsdoc comments Sep 30, 2025
@alexisintech alexisintech merged commit 23b37fc into main Sep 30, 2025
45 checks passed
@alexisintech alexisintech deleted the aa/fix-typedoc-links branch September 30, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants