Skip to content

Conversation

wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Oct 5, 2025

Reverts #6802

The original intent of the PR is to fix issues with setTransitiveState() in non-React apps, but looks like it introduced another issue (#6904). We have plans to kill setTransitiveState() so I guess it's better to wait for that than to patch it like this.

Summary by CodeRabbit

  • Refactor
    • Simplified client-side navigation by removing an unnecessary asynchronous wrapper, making routing calls more direct.
  • Performance
    • Slight improvement to navigation responsiveness by eliminating extra scheduling overhead.
  • Chores
    • Added a changeset noting this minor routing update.

Copy link

changeset-bot bot commented Oct 5, 2025

🦋 Changeset detected

Latest commit: 4114153

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/nuxt Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Oct 5, 2025 7:57pm

Copy link
Contributor

coderabbitai bot commented Oct 5, 2025

Walkthrough

Removed nextTick wrapping from Nuxt runtime navigation helpers. routerPush now directly calls navigateTo(to) and routerReplace calls navigateTo(to, { replace: true }); unused nextTick import and a related ts-expect-error comment were removed.

Changes

Cohort / File(s) Summary of Changes
Nuxt runtime plugin navigation
packages/nuxt/src/runtime/plugin.ts
Removed nextTick wrapper around routerPush/routerReplace; now directly call navigateTo and navigateTo(..., { replace: true }). Removed unused nextTick import and a ts-expect-error comment.
Changeset
.changeset/ten-poets-agree.md
Added changeset noting removal of nextTick calls in Clerk/Nuxt routing helpers.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant App
  participant Router

  rect rgba(220, 248, 207, 0.6)
  note over App: New flow (direct)
  User->>App: routerPush(to) / routerReplace(to)
  App->>Router: navigateTo(to) / navigateTo(to, { replace: true })
  Router-->>User: Navigation handled
  end

  rect rgba(255, 243, 207, 0.6)
  note over App: Prior flow (queued)
  User->>App: routerPush(to) / routerReplace(to)
  App->>App: nextTick(() => ...)
  App->>Router: navigateTo(...)
  Router-->>User: Navigation handled
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hop the path without delay,
No ticking pause along the way.
A gentle push, a swapping stride,
Direct to carrots on the ride.
Small change, big hop—let's glide! 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly states that this pull request reverts the previous Nuxt routing fix and directly corresponds to the changes being rolled back, specifying the original commit’s description without extraneous detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-6802-rob/nuxt-fix-transition

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 12e36c4 and 4114153.

📒 Files selected for processing (1)
  • .changeset/ten-poets-agree.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Automated releases must use Changesets.

Files:

  • .changeset/ten-poets-agree.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (29)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (handshake, chrome)
  • GitHub Check: Integration Tests (handshake:staging, chrome)
  • GitHub Check: Integration Tests (tanstack-react-router, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
  • GitHub Check: Unit Tests (22, **)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Static analysis
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

Comment on lines +1 to +5
---
"@clerk/nuxt": minor
---

Remove added `nextTick()` calls when invoking Clerk routing functions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Changeset summary contradicts the revert.

This PR restores the nextTick wrapper, yet the changeset still advertises removing it. Shipping this note would mislead downstream consumers and trigger an incorrect minor release. Please delete this changeset or replace it with one that accurately states the revert (likely a patch note explaining that the previous change was rolled back).

🤖 Prompt for AI Agents
.changeset/ten-poets-agree.md lines 1-5: the changeset message advertises
removing nextTick and marks a minor bump but this PR actually reverts that
change; either delete this changeset or update it to accurately describe the
revert and use a patch release. Replace the body summary to state that the
previous removal of nextTick was reverted (restored behavior), change the
release type from "minor" to "patch" (or remove the file if you prefer no
release note), and ensure the changelog text clearly explains the rollback.

Copy link

pkg-pr-new bot commented Oct 5, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6928

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6928

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6928

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6928

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6928

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6928

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6928

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6928

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6928

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6928

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6928

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6928

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6928

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6928

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6928

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6928

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6928

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6928

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6928

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6928

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6928

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6928

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6928

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6928

commit: 4114153

@wobsoriano wobsoriano requested a review from tmilewski October 6, 2025 16:45
tmilewski

This comment was marked as resolved.

@wobsoriano wobsoriano merged commit 6dfb3ec into main Oct 6, 2025
74 of 76 checks passed
@wobsoriano wobsoriano deleted the revert-6802-rob/nuxt-fix-transition branch October 6, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants