Skip to content

Conversation

panteliselef
Copy link
Member

@panteliselef panteliselef commented Oct 10, 2025

This reverts commit 4910194.

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Refactor

    • Removed several billing-related type exports from the backend SDK to streamline the public API. If you relied on these for payer or webhook payloads, migrate to the current billing resources or define local types.
  • Chores

    • Removed an outdated changeset entry and added a non-functional placeholder changeset; no behavioral changes.

Copy link

changeset-bot bot commented Oct 10, 2025

🦋 Changeset detected

Latest commit: 17c82b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Oct 10, 2025 7:04pm

Copy link
Contributor

coderabbitai bot commented Oct 10, 2025

Walkthrough

Deleted one changeset file and added another empty changeset; removed four publicly re-exported JSON billing-related types from packages/backend/src/index.ts. No runtime logic or control-flow changes were introduced.

Changes

Cohort / File(s) Summary
Changelog files
.changeset/warm-steaks-count.md, .changeset/empty-forks-wink.md
Deleted warm-steaks-count.md (removed a changelog entry referencing exported Billing types); added empty-forks-wink.md containing empty front-matter (---). No code changes.
Backend JSON export surface
packages/backend/src/index.ts
Removed four re-exports from ./api/resources/JSON: BillingPayerJSON, BillingPaymentAttemptWebhookEventJSON, BillingSubscriptionItemWebhookEventJSON, BillingSubscriptionWebhookEventJSON. No other code or runtime behavior changed.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

I nibble notes beside the stream,
A changelog slips into a dream.
Four types hopped out to roam,
The export burrow feels like home.
I twitch my nose and hum—contented, small and keen. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly states that this pull request reverts the earlier fix for exporting missing Billing types and references the original PR number, accurately summarizing the main purpose of the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch elef/revert-billing-type-exports

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8f83519 and 17c82b6.

📒 Files selected for processing (1)
  • .changeset/empty-forks-wink.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .changeset/empty-forks-wink.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (29)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (handshake, chrome)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (handshake:staging, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
  • GitHub Check: Unit Tests (22, **)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Static analysis
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

pkg-pr-new bot commented Oct 10, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6960

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6960

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6960

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6960

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6960

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6960

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6960

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6960

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6960

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6960

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6960

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6960

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6960

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6960

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6960

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6960

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6960

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6960

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6960

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6960

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6960

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6960

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6960

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6960

commit: 17c82b6

@panteliselef panteliselef merged commit 0835ee7 into main Oct 10, 2025
93 of 97 checks passed
@panteliselef panteliselef deleted the elef/revert-billing-type-exports branch October 10, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants