Skip to content

Refactor script for multiple validators #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Refactor script for multiple validators #11

wants to merge 34 commits into from
+1,137 −1,350

Conversation

royanger
Copy link
Member

@royanger royanger commented Mar 4, 2024

No description provided.

royanger added 21 commits March 2, 2024 02:42
@royanger
(wip) Started refactor, added CLI, started moving validators to their…
2df236e 
… own space
@royanger
(wip) Added Supabase validator
ee654d0
@royanger
(wip) Check if the file exists
58fe501
@royanger
(wip) Reading from .json, and from .csv into JSON
bc86a10
@royanger
(wip) Moved validator list to constant, generate CLI options on deman…
335b642 
…d from that constant
@royanger
(wip) Moved validators into their own directory, added metadata to ea…
5a28fc6 
…ch file, generated list from files
@royanger
(wip) Minor improvements,some more typing
a43625b
@royanger
(wip) Refactored to transform incoming data to expected schema
bdad2f6
@royanger
(wip) Basic import is now working
7a02123
@royanger
(wip) Cleanup and adding spinners + messaging
8367ee7
@royanger
(wip) Added logger, some cleanup
398e9ec
@royanger
(wip) Improved logger, creates directories as needed
3f400b2
@royanger
(wip) Improved logger significantly, removed blank/empty entries from…
f2d6e6a 
… .csv, cleanup
@royanger
(wip) Added eslint
e959bc0
@royanger
(wip)
34f3768
@royanger
(wip) Added prettier
28b852e
@royanger
(wip) Removed spinner that was added just for testing.
969c4a1
@royanger
(wip) Added Supabase JSON sample
63fa0fd
@royanger
(wip) Added transform/validation to JSON and CSV
6d5f6a4
@royanger
Removed need for different handler filers, combined into one.
242d0e7
@royanger
Formatting
4af9dab
@royanger royanger requested a review from JacobMGEvans March 4, 2024 04:53
JacobMGEvans
JacobMGEvans reviewed Mar 4, 2024
View reviewed changes
JacobMGEvans
JacobMGEvans reviewed Mar 4, 2024
View reviewed changes
Copy link
Contributor

@JacobMGEvans JacobMGEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos

@royanger royanger requested a review from JacobMGEvans March 4, 2024 22:43
@JacobMGEvans
Copy link
Contributor

Is this still pending approval by @domitriusclark or someone else?

JacobMGEvans
JacobMGEvans approved these changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@JacobMGEvans JacobMGEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to add more tests, but the tests for various inputs and how they map to Clerk are a good start.

@JacobMGEvans
Copy link
Contributor

Lets merge this.

@royanger
Copy link
Member Author

Lets merge this.

Not yet. There is some outstanding work outlined in the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@JacobMGEvans JacobMGEvans JacobMGEvans approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@royanger @JacobMGEvans @jescalan