Fix grammar in repo create prompt
#5557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it looks like you could use "there's" informally, grammatically, it should be "are" since "commits" is plural. <https://dictionary.cambridge.org/us/grammar/british-grammar/there-is-there-s-and-there-are>
cliAutomation
added
the
external
|
Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message. |
I created a remote called "github" and got this prompt: > Would you like to push commits from the current branch to the "github"? Normally, the default name "origin" doesn't sound bad in that prompt, but using the name "github" made the prompt sound like something wasn't right to my American English-speaking ears. Here are a few options. Yes, I know English grammar sucks, to put it mildly. But, hopefully, the following options and explanations make sense. Get rid of "the". This is the option I went with. "github" acts as a proper noun, so no determiner is needed. If you substitute your own name for "github" in the original prompt above, you get the same effect: > Would you like to push commits from the current branch to "github"? Add the implicit word "remote". "github" now acts as an adjective and "the" refers to "remote": > Would you like to push commits from the current branch to the "github" remote? Or, combine the two. This last option relies on the fact that instructions and manuals often omit definite articles because most articles are definite. See the [zero-marking][2] article on Wikipedia. The original prompt already does this by omitting "the" before the word "commits": > Would you like to push commits from the current branch to "github" remote? Reference: [1]: http://writing.umn.edu/sws/quickhelp/grammar/articlesproper.html [2]: https://en.wikipedia.org/wiki/Zero-marking_in_English
chemotaxis
force-pushed
the
fix-grammar-repo-create_20220501
branch
from
ed69fe8
to
a19c166
Compare
samcoe
approved these changes
May 2, 2022
This was referenced Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a more detailed explanation in the commit message, but there is a stray "the" in the prompt for creating a remote:
This pull request omits "the":