defines a single docker image with api server and localstack db #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this image can be used in the local development workflow for the frontend, which would mean no need to also pull and start the backend repo. areas for future improvement: 1. the `localstack/localstack` base image runs everything as `root`, which we should change to a user with less privileges 2. we could probably make the image smaller by doing a multi-stage build, so we don't include the `src` directory and npm dev dependencies in the final image.
rgraue
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this image can be used in the local development workflow for the frontend, which would mean no need to also pull and start the backend repo.
areas for future improvement:
localstack/localstackbase image runs everything asroot, which we should change to a user with less privilegessrcdirectory and npm dev dependencies in the final image.