Integrate @adguard/tsurlfilter

[mjethani]

Let's integrate the @adguard/tsurlfilter library into the benchmarks.

[mjethani]

@ameshkov

To try this out:

git clone -b integrate-tsurlfilter https://github.com/mjethani/adblocker
cd adblocker/packages/adblocker-benchmarks
npm install
make tsurlfilter

[ameshkov]

Submodule path 'blockers/ublock/submodules/uAssets': checked out '9df535fe7955996069377cbc63631a51aaeb72cd'
make -C ./blockers/ublock install-nodejs clean
tools/make-nodejs.sh
tools/make-nodejs.sh: line 61: eslint: command not found
make[1]: *** [dist/build/uBlock0.nodejs] Error 127
make: *** [node_modules/@gorhill/ubo-core] Error 2
error Command failed with exit code 2.

Requires globally installed eslint?

[mjethani]

Requires globally installed eslint?

Sorry about this. The @gorhill/ubo-core integration is also a work in progress. Yes, it requires global ESLint.

[mjethani]

@ameshkov use make tsurlfilter SHOW_MEMORY=1 to see information about memory usage (work in progress!). Use make brave, make ublock, make adblockplus, and make cliqz to run benchmarks for the respective content blocker.

[ameshkov]

@ameshkov use make tsurlfilter SHOW_MEMORY=1 to see information about memory usage (work in progress!). Use make brave, make ublock, make adblockplus, and make cliqz to run benchmarks for the respective content blocker.

Great, thank you, that's a great tool and we'll definitely be using it to measure the impact of the new changes.

On a side note, it probably makes sense to add info about requirements somewhere, I noticed it also requires rust.

[mjethani]

… we'll definitely be using it to measure the impact of the new changes.

I can second this. I used it a lot for the optimization of Adblock Plus.

… probably makes sense to add info about requirements

Thanks! I'm trying to address the ESLint issue: gorhill/uBlock#3803 As for Rust, I guess we'll have to mention it in the requirements.

[mjethani]

@remusao I guess it looks good to @ameshkov so I've marked it as ready for review. Let me know if you have any comments and then we can merge it.

[mjethani]

@ameshkov @remusao thanks for your time!

Note that we are also benchmarking serialization and deserialization and I have skipped this for @adguard/tsurlfilter to keep it simple for now.