remove zero-byte restriction in keyvi, to allow search of arbitrary binary data #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmuhs
changed the title
| uint64_t state = fsa_->GetStartState(); | ||
| size_t key_length = strlen(key); | ||
| size_t key_length = key.size(); |
There was a problem hiding this comment.
In general I prefer and have a habit to define variables which are not going to be changed as const. This improves readability, prevents from some errors and even sometimes can help compiler to generate more efficient code.
There was a problem hiding this comment.
👍 changing at least the lines I touched
hendrikmuhs
changed the title
| uint64_t state = fsa_->GetStartState(); | ||
| size_t text_length = strlen(key); | ||
| size_t text_length = key.size(); |
| @@ -220,7 +218,7 @@ final { | |||
| stack_->UpdateWeights(0, input_key.size() + 1, weight); | |||
| } | |||
|
|
|||
| last_key_ = key; | |||
| last_key_ = std::move(input_key); | |||
There was a problem hiding this comment.
input_key is a const, so std::move call will return const std::string&& which is not the same as std::string&& and in the end anyway copy-constructor will be called as it's a better match, not move
|
rebased in #115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.