Skip to content

CI - Test that quickstart-chat builds #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 9, 2025
Merged

CI - Test that quickstart-chat builds #197

merged 10 commits into from
Jul 9, 2025

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented Jul 8, 2025 •
edited
Loading

Description of Changes

Test quickstart-chat in CI. This is for #182.

It turns out we had mostly-working code to do this, but it was commented out.

API

  • This is an API breaking change to the SDK

No breaking changes

Requires SpacetimeDB PRs

None

Testing

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 514405a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bfops bfops changed the title Test quickstart-chat in CI CI - Test quickstart-chat Jul 8, 2025
@bfops bfops linked an issue Jul 8, 2025 that may be closed by this pull request
Add CI check that quickstart-chat at least typechecks #182
Closed
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 8, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@clockworklabs/spacetimedb-sdk@197

commit: 514405a

@bfops bfops requested a review from jsdt July 8, 2025 22:37
bfops
bfops commented Jul 8, 2025
View reviewed changes
@bfops bfops marked this pull request as ready for review July 8, 2025 22:44
@bfops bfops changed the title CI - Test quickstart-chat CI - Test that quickstart-chat builds Jul 8, 2025
bfops
bfops commented Jul 9, 2025
View reviewed changes
@bfops bfops merged commit fdd4618 into main Jul 9, 2025
8 checks passed
@bfops bfops deleted the bfops/quickstart-ci branch July 9, 2025 16:47
bfops added a commit that referenced this pull request Jul 29, 2025
@bfops
CI - Test that quickstart-chat builds (#197)
5a9e8d3 
* Test quickstart-chat in CI

* fix?

* ignore diffs containing SpacetimeDB commit

* prettier config

* fix?

* [REVERT THIS TEST COMMIT] add diff to module bindings

* revert previous test commit

* [REVERT THIS TEST COMMIT] introduce a typechecking error

* revert previous test commit

* tiny review

---------

Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsdt jsdt jsdt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CI check that quickstart-chat at least typechecks
2 participants
@bfops @jsdt