Rewrite the namespace part of track-state #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't build the namespace map ourselves, just use ns-map. - Don't track changes in namespaces from jar files. - Since the client still needs to know what's in these jar namespaces, we send their info on the first message, but we ONLY do that for namespaces that are :require'd by a source namespace. This guarantees we only send namespaces that are potentially useful, and reduces the amount of garbage we send on the first message This fixes a lag of about 300ms between receiving eval result and receiving the "done" status, which translated as a lag on printing the repl prompt. This might solve clojure-emacs/cider#1320, depending on the size of project namespaces, but we should probably still offer a way to disable it.
bbatsov
added a commit
that referenced
this pull request
Sep 15, 2015
Rewrite the namespace part of track-state
|
👍 |
|
Btw, a further optimization might be not to send all the vars unless the client actually needs them (depending on the config option for the font-locking). We can just add some command users have to run if they change the config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we send their info on the first message, but we ONLY do that for
namespaces that are :require'd by a source namespace. This guarantees
we only send namespaces that are potentially useful, and reduces the
amount of garbage we send on the first message
This fixes a lag of about 300ms between receiving eval result and
receiving the "done" status, which translated as a lag on printing the
repl prompt.
This might solve clojure-emacs/cider#1320, depending on the size of
project namespaces, but we should probably still offer a way to disable
it.