Skip to content

jack-in: move Clojure-cli parameter global-opts after -Sdeps #2917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2020
Merged

jack-in: move Clojure-cli parameter global-opts after -Sdeps #2917

merged 1 commit into from
Oct 24, 2020

Conversation

practicalli-johnny
Copy link
Contributor

@practicalli-johnny practicalli-johnny commented Oct 23, 2020

Move the aliases (global-opts) after the -Sdeps dependencies in cider-jack-in to
match the order of arguments to the clojure command line tool.

This fix has been successfully tested with the new -M flag and the classic -A flag for defining aliases for the Clojure CLI tools.

Resolves #2916

  • The commits are consistent with our contribution guidelines - confirmed
  • You've added tests - no additional tests required
  • All tests are passing (eldev test) - all tests passed
  • All code passes the linter (eldev lint) - no warnings on changed file, cider.el (warnings in other files that were not changed)
  • changelog - added fix and referenced issue
  • user manual - no visual change

Move the aliases (global-opts) after the -Sdeps dependencies in cider-jack-in to
match the order of arguments to the clojure command line tool.

Resolves #2916
@practicalli-johnny
Copy link
Contributor Author

practicalli-johnny commented Oct 23, 2020

Lint warnings were generated for the cider-connection.el and cider-doc.el files. Those files have not been changed by this PR.

Raises an issue related to this to fix the lint files for unrelated changes
#2918

@bbatsov bbatsov merged commit fde37a3 into clojure-emacs:master Oct 24, 2020
@bbatsov
Copy link
Member

bbatsov commented Oct 24, 2020

Thanks!

@practicalli-johnny practicalli-johnny deleted the clojure-cli-parameter-order-fix branch October 26, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clojure CLI command parameters order incorrect
2 participants