-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cider 0.8.1 does not accurately display errors #895
Comments
This is a Clojure bug. See http://dev.clojure.org/jira/browse/CLJ-1568. If you'd like to see it fixed I'd suggest upvoting the ticket. |
Ah, ok. What about the issue with the empty cider-error buffer (see the third attachment)? This seemed to start happening with the 0.8 release. |
I can't reproduce the problem with the missing stacktrace buffer. |
You can check your |
I also dont get any feedback from tests anymore. I see the response coming in
Might be related as well. |
I need some minimal repro case for this. So far I've never run into any of the two problems myself. |
wonder what was wrong. I cannot reproduce it anymore. I updated magit and graphviz mode to latest versions of melpa-stable and problem seems to be gone. Can it be there was some kind of odd conflict? |
I'm stuck hitting the "empty Dumb question: I don't have a |
I had the same issue in @mrcslws You need to do the following to enable message logging:
This is probably related to #881 btw. I'll see if I can reproduce this evening. |
Empty Does anyone know how to downgrade to |
Ahh, see here for how to get an |
I'm getting the same empty cider-error buffer as others on 0.8.1. |
I'm guessing some of you might have some leftovers of previous CIDER versions around. Can't think of another explanation why this problem isn't observed by all users. |
Actually, I'm finding that I get into this state after printing something large. Consistent repro steps:
|
Hi Bozhidar, appreciate the response. Could you possibly point me to some info for an emacs novice re: how to clear previous versions and I'll let you know if it helps in my case? Cheers! :-) |
if you installed your previous versions through elpa you find the installations in |
FWIW, I deleted the 0.7 package before installing 0.8.1, and I'm seeing this. |
Yeah, I think this is project-specific, not related to upgrades. I see it with a freshly-cloned https://github.com/nupic-community/comportex but not with other projects that I've tried. I used my repro steps above. |
Thanks @jgeraerts, I can confirm then that removing the old cider versions did not help in my case. Errors still result in a blank Would be happy to run any other tests or gather any other info that might help with diagnosing the cause. Cheers! |
@mrcsiws, could you please give more concrete steps of how to reproduce? I have loaded |
Hmm even with my repro steps above? This comment: #895 (comment) |
I only noticed this after I installed clojure-mode 3.0.1 (that doesn't mean that it only happened after that, but I can only say for certain that I noticed it after that). Deleting the entire |
Deleting |
I can reproduce it with |
Jvm optimizes the stacktrace out:
More info here. The solution is to add The only fix on Cider side I can think of is to give a meaningful message on empty stacktrace. |
lein looks for |
Hi Vitalie, thanks for the suggestion! Unfortunately I can confirm that adding Still seeing the same empty Cheers :-) |
@ptaoussanis, there might be multiple issues with the stacktrace. What does |
Returns the StackTrace as expected,
Trying to eval
|
@ptaoussanis, your problem is on @mrcslws, does the |
I am having the exact same experience as @ptaoussanis. I'm not getting any elisp errors in Messages buffer. |
I am having exactly the same messages as @ptaoussanis posted and everything works as expected. I am afraid you will have to try to debug it yourself. Unfortunately edebug doesn't enter into |
I know very little about elisp or how to debug it. I'm happy to help try to troubleshoot this as much as I can. I was able to check that
|
:-). |
Seems to me you're actually running some command from |
Ok. I must be doing something wrong. I have |
Ok. We are getting somewhere then. Try to debug |
Sorry. I should have mentioned that I tried the edebug thing in the other two functions you mentioned - |
Ran Then eval
There is no new content in
Confirmed, it's the same version (
Eval
Tried Am either doing something wrong, or none of the these functions is ever being called? I've never done elisp development. To confirm: if I replace the whole (defun cider-stacktrace-render (buffer causes)
"Emit into BUFFER useful stacktrace information for the CAUSES."
(debug)) Then call |
Hold up, I think I got it working - will update once I've confirmed the solution. |
Okay, when I eval What it took in my case was manually removing [/moving] my entire I'd previously tried to delete + reinstall just I was hoping to swap in the old dir and start reinstalling one-by-one to try and pinpoint the actual package(s) that needed reinstalling - but it seems I can't reproduce the error now. I'm not sure if emacs is caching this stuff somewhere? In any case, this did help in my case - and does seem to point at the behaviour being some sort of an installation cruft/cache problem. One (unrelated?) oddity: when I eval an error form in a Clojure namespace (let's say Much thanks for all the assistance on this - and for your work on Cider generally. Really appreciate it. Cheers! :-) |
This is the Clojure bug mentioned in this very ticket (+ CIDER's auto-jump-to-error). |
Sorry, to confirm: the cursor jumping to the top of the ns is related to http://dev.clojure.org/jira/browse/CLJ-1568? So CIDER is jumping to the reported [incorrect] line number? I'll vote for the issue, but any suggested workarounds in the meantime? Perhaps just disabling the jump entirely? |
Yes. Most commonly it's that Emacs loads some older compiled .elc files. These issues are notoriously difficult to debug for non-elispers.
Clojure 1.5.1 works fine. I have been planing for an improvement to Cider's error navigation (dissucussed in #851) which will fix this issue by side effect. @bbatsov, can you reopen #851? Github auto-closed it when #866 was merged. |
Fantastic, thank you! In the meantime, assuming a Clojure version downgrade is infeasible - is there any CIDER code I can mod to just disable the auto jumps for now? I see in #851 that your PR originally had some changes for this - but the commits aren't showing up under #851 any more. EDIT: Have just disabled the |
Customize |
I installed 0.8.2 from melpa stable and the problem went away. |
I created a project using the default lein template and then added and attempted to evaluate a bad expression. The reporting does not seem to be working. Here is the code:
When I evaluate this, the cider-error buffer pops up but it is empty. If I switch back to the cider-repl buffer then I can see the error, but it's pointing to the wrong line number. The line number differs depending on if I evaluate the whole buffer
C-c C-k
or just evaluate the single expressionC-c C-e
. Both reported line numbers point to valid code, and the line containing the actual error (an unquoted list of numbers passed as an argument) is never highlighted. See attached screenshots.The text was updated successfully, but these errors were encountered: