Fix buggy special-display-buffer-names check. #3673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes issue #3672 |
bbatsov
reviewed
May 21, 2024
| @@ -64,7 +64,7 @@ by adding BUFFER-NAME to the `special-display-buffer-names' list." | |||
| ;; another time through `cider-popup-buffer-display'): | |||
| (if (and (boundp 'special-display-buffer-names) | |||
| (seq-find (lambda (entry) | |||
| (equal (car entry) buffer-name)) | |||
| (equal (if (listp entry) (car entry) entry) buffer-name)) | |||
There was a problem hiding this comment.
This is because code in function cider-popup-display-buffer falsely assumes that each element of special-display-buffer-names is a list. In fact and as documented, each element can be either a string or a list (the car of which is a string).
Can you add some variant of this as a comment here for clarity's sake?
|
I'm fine with the proposed change. Just add some comment about it and a changelog entry as well. |
|
Done
…On Tue, 21 May 2024 at 12:09, Bozhidar Batsov ***@***.***> wrote:
I'm fine with the proposed change. Just add some comment about it and a
changelog entry as well.
—
Reply to this email directly, view it on GitHub
<#3673 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADNWMR2W64JTGBMZB5PAZLZDMTQJAVCNFSM6AAAAABIBNDGQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRSGM4DOOBSGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this placeholder text with a summary of the changes in your PR.
The more detailed you are, the better.
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test)eldev lint) which is based onelisp-lintand includescheckdoc, check-declare, packaging metadata, indentation, and trailing whitespace checks.Thanks!
If you're just starting out to hack on CIDER you might find this section of its
manual extremely useful.