@(dynamic)variable shouldn't break fontlock #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change looks good, but it needs a couple of font-lock unit tests (see the existing tests for reference). |
tanzoniteblack
force-pushed
the
deref-font-lock
branch
from
df48cfd to
42574c9
Compare
Currently `foo/some-var` will fontlock `foo`, but if this item is something that can be dereffed and you type `@foo/some-var`, `foo` is no longer font-locked. Similarly: `*dynamic-var*` is font locked, but `@` breaks the regex. In this change the `@` sign isn't font locked, but the var that follows it is. Conflicts: clojure-mode.el Add tests for dynamic-var and ns/refer fontlock
tanzoniteblack
force-pushed
the
deref-font-lock
branch
from
42574c9 to
ed636c9
Compare
|
I've added tests to verify the fontlock works (the 2nd statement in each tests fails if you attempt to run against master, which is what we'd expect) and have squashed it all into one commit for a prettier git history. |
bbatsov
added a commit
that referenced
this pull request
Aug 22, 2014
@(dynamic)variable shouldn't break fontlock
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
foo/some-varwill fontlockfoo, but if this item issomething that can be dereffed and you type
@foo/some-var,foois nolonger font-locked.
Similarly:
*dynamic-var*is font locked, but@breaks the regex.In this change the
@sign isn't font locked, but the var that followsit is.