Skip to content

Conversation

m00nlight
Copy link
Contributor

Add some missing functions for font lock, from the function list of document 1.6

https://clojure.github.io/clojure/clojure.core-api.html

@@ -130,6 +130,16 @@
"with-bindings" "with-bindings*" "with-in-str" "with-loading-context"
"with-meta" "with-out-str" "with-precision"
"with-redefs" "with-redefs-fn" "xml-seq" "zero?" "zipmap"
"dec" "denominator" "error-handler" "error-mode" "every-pred"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this entire list ordered by name.

@m00nlight
Copy link
Contributor Author

@bbatsov Done :)

@bbatsov
Copy link
Member

bbatsov commented Dec 30, 2014

Looks good. Just squash the two commits together.

@m00nlight
Copy link
Contributor Author

@bbatsov What do you mean by saying "squash the two commits together"? Sorry I am not an English native speaker.

@bbatsov
Copy link
Member

bbatsov commented Dec 30, 2014

@m00nlight
Copy link
Contributor Author

@bbatsov Something seems wrong? When I squash the last to commit as you teach me, I failed to push to remote to github, it hint me to pull first and push again. How can I do it correctly?

@bbatsov
Copy link
Member

bbatsov commented Dec 30, 2014

Use push -f.

On Tuesday, December 30, 2014, m00nlight notifications@github.com wrote:

@bbatsov https://github.com/bbatsov Something seems wrong? When I
squash the last to commit as you teach me, I failed to push to remote to
github, it hint me to pull first and push again. How can I do it correctly?


Reply to this email directly or view it on GitHub
#268 (comment)
.

Best Regards,
Bozhidar Batsov

http://www.batsov.com

@m00nlight m00nlight force-pushed the add-missing-functions branch from 7dfe030 to 00b0c09 Compare December 30, 2014 08:41
@m00nlight
Copy link
Contributor Author

@bbatsov I think it is OK now, right?

@bbatsov
Copy link
Member

bbatsov commented Dec 30, 2014

Yep. Just remove the second line from the commit message as it's not very useful.

@expez
Copy link
Member

expez commented Dec 30, 2014

.

Maybe cut new contributors some slack, @bbatsov 😀 ?

@m00nlight m00nlight force-pushed the add-missing-functions branch from 00b0c09 to 6017a9c Compare December 31, 2014 07:43
@m00nlight
Copy link
Contributor Author

@bbatsov : Sorry for some private fairs, Done now :)

bbatsov added a commit that referenced this pull request Dec 31, 2014
Add some missing functions for font lock
@bbatsov bbatsov merged commit b1b0670 into clojure-emacs:master Dec 31, 2014
@bbatsov
Copy link
Member

bbatsov commented Dec 31, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants