Skip to content

Form alignment #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 1, 2016
Merged

Form alignment #347

merged 2 commits into from
Jan 1, 2016

Conversation

Malabarba
Copy link
Member

Much nicer now.
This hooks into indent-line, so that no extra commands are required.

If the user wants, a command is provided as well. We could bind it to C-c SPC in analogy to C-x SPC.

@bbatsov
Copy link
Member

bbatsov commented Nov 17, 2015

We could bind it to C-c SPC in analogy to C-x SPC.

Sounds good to me.

A changelog entry should be added as well. Probably we should mention this in the README as well.

@bbatsov
Copy link
Member

bbatsov commented Nov 18, 2015

Btw, I'm guessing you can add this to lisp-mode/elisp-mode down the road. Plenty of people would like it.

@bbatsov
Copy link
Member

bbatsov commented Nov 27, 2015

We should wrap this as well. I know that a bunch of people are quite excited about the feature.

@Malabarba
Copy link
Member Author

I know, it's on my list. But I'm still going through bug fixes for the cider release. :)

@bbatsov
Copy link
Member

bbatsov commented Nov 27, 2015

But I'm still going through bug fixes for the cider release. :)

Yeah, those are way more important in the short term for sure. :-)

@bbatsov
Copy link
Member

bbatsov commented Dec 8, 2015

We could bind it to C-c SPC in analogy to C-x SPC.

That sounds reasonable. I missed it when I was originally reading the description. Once this and the comment changes are finalized I'll probably release them as 5.1.

@bbatsov bbatsov mentioned this pull request Dec 18, 2015
@Malabarba
Copy link
Member Author

PR updated.

@Malabarba
Copy link
Member Author

And (I should say) heavily changed. It now uses the align-region function, instead of aligning manually, though we still have to do quite a bit of work because our alignment is sexp-based, and not regexp based.

bbatsov added a commit that referenced this pull request Jan 1, 2016
@bbatsov bbatsov merged commit 95d38cd into master Jan 1, 2016
@bbatsov bbatsov deleted the form-alignment branch January 1, 2016 23:34
@bbatsov
Copy link
Member

bbatsov commented Jan 1, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants