[Fix #277] Apply font-lock-comment-face to (comment) and #_

[Malabarba]

No description provided.

[bbatsov]

As I noted in the original I have some doubts about applying this to comment, as the behaviour there's not exactly the same as with #_ (e.g. comment returns a result nil).

@expez What do you think?

[bbatsov]

I've almost never seen setf in Emacs Lisp code (although it was quite popular in CL).

[Malabarba]

I almost always use it to destructively change a sequence or struct. :-)
It's considerably more convenient than something like (setcar (cdr (cdr (cdr md))) start).

[bbatsov]

Fair enough. :-) I just said it's pretty uncommon.

[bbatsov]

Two more remarks - this needs a changelog entry and maybe there should be some config option about the comment macro. Anyways, let's hear what @expez and possibly others would have to say about the change.

[expez]

I don't think we should font-lock comment with comment face. The only time I see the comment macro used is to provide example usage, or to put some code in the buffer which can easily be evaluated (e.g. with C-c C-e) while developing. In those two scenarios font-locking is quite beneficial.

I don't have time right now, but I think it would be a good idea to run a code search on github to check out how people are using comment.

[Malabarba]

I'll remove the comment macro support and just add an example on the docstring about how to support it.

[bbatsov]

Sounds good to me.

[bbatsov]

👍