Skip to content

Conversation

carlosgeos
Copy link
Contributor

@carlosgeos carlosgeos commented Jan 21, 2019

Fixes what is said here: #445 (comment). The regex could be improved so feedback appreciated. Basically, it has to exclude words starting with : so it does not apply function-name-face to them (they are keywords)


Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

  • The commits are consistent with our [contribution guidelines][1].
  • You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
  • You've run M-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

@bbatsov bbatsov requested a review from cichli February 23, 2019 11:27
Copy link
Member

@cichli cichli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this. All looks good to me, please squash the commits though.

@cichli cichli merged commit e931d08 into clojure-emacs:master Feb 27, 2019
@cichli
Copy link
Member

cichli commented Feb 27, 2019

Thanks again for this set of PRs, it's greatly appreciated! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants