Skip to content

Conversation

wigust
Copy link
Contributor

@wigust wigust commented Aug 29, 2020

This commit fixes tests on Emacs 27.1 (fixes #568).


Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

  • The commits are consistent with our contribution guidelines.
  • You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
  • You've run M-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

Thanks!

@wigust
Copy link
Contributor Author

wigust commented Aug 29, 2020

Also, please consider creating a new release by pushing a Git tag, so it could be used in Guix instead of pointing to commit.

@manuel-uberti
Copy link
Contributor

IIUC, in project.el 0.5.2 has been made obsolete in favour of project-root. Would it make sense to use and document that one instead?

@bbatsov bbatsov merged commit 4de7e02 into clojure-emacs:master Sep 18, 2020
@bbatsov
Copy link
Member

bbatsov commented Sep 18, 2020

IIUC, in project.el 0.5.2 has been made obsolete in favour of project-root. Would it make sense to use and document that one instead?

clojure-mode doesn't depend on project.el as a package, so it will use whatever version comes bundled with Emacs, so I don't think we can switch to the new name just yet. Better compatibility trumps an obsoletion warning in my book.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

documentation tests fail with Emacs 27.1 (release candidate)
3 participants