Fix #56 Add special handling for Planck REPLS #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichiardi
reviewed
Mar 24, 2017
inf-clojure.el
Outdated
| @@ -236,7 +237,15 @@ Clojure to load that file." | |||
| (define-obsolete-variable-alias 'inf-clojure-load-command 'inf-clojure-load-form "2.0.0") | |||
|
|
|||
| (defcustom inf-clojure-load-form-lumo "(clojure.core/load-file \"%s\")" | |||
| "Format-string for building a Clojure expression to load a file. | |||
| "Planck format-string for building a Clojure expression to load a file. | |||
There was a problem hiding this comment.
Maybe little typo here, shouldn't it be for Lumo? I have probably forgot to update this one myself 😄
inf-clojure.el
Outdated
| @@ -272,7 +282,7 @@ This should usually be a combination of `inf-clojure-prompt' and | |||
| :package-version '(inf-clojure . "2.0.0")) | |||
|
|
|||
| (defvar inf-clojure-buffer nil | |||
| "The current inf-clojure process buffer. | |||
| "The current ‘inf-clojure’ process buffer. | |||
There was a problem hiding this comment.
Oh just out of curiosity, why those forward ticks?
There was a problem hiding this comment.
checkdoc suggested it. removed
8929305
inf-clojure.el
Outdated
| @@ -649,12 +680,19 @@ If you are using REPL types, it will pickup the most approapriate | |||
| :type 'string | |||
| :package-version '(inf-clojure . "2.0.0")) | |||
|
|
|||
| (defcustom inf-clojure-completion-form-planck | |||
| "(doall (map str (planck.repl/get-completions \"%s\")))\n" | |||
There was a problem hiding this comment.
this (doall (map str ... was necessary because lumo returns #js. Does planck return it as well?
| @@ -685,6 +730,20 @@ If you are using REPL types, it will pickup the most approapriate | |||
| :type 'string | |||
| :package-version '(inf-clojure . "2.0.0")) | |||
|
|
|||
| (defcustom inf-clojure-set-ns-form-planck | |||
| "(in-ns '%s)\n" | |||
There was a problem hiding this comment.
Seems like in-ns lives in top-level
cljs.user=> (doc in-ns)
-------------------------
in-ns
([name])
REPL Special Function
Sets *cljs-ns* to the namespace named by the symbol, creating it if needed.
nil
cljs.user=> (doc apropos)
-------------------------
planck.repl/apropos
([str-or-pattern])
Macro
Given a regular expression or stringable thing, return a seq of all
public definitions in all currently-loaded namespaces that match the
str-or-pattern.
There was a problem hiding this comment.
Right, Planck's in-ns is a REPL special (just like in the ClojureScript REPL). It has no namespace.
|
Thanks for the review @arichiardi! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the Planck REPL
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
M-x checkdocwarningsThanks!