Fix behaviour of "standard input" on Unix-like operating systems #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axvr
changed the title
|
I'll take it any way I can get it. :)
I've been aware of this behavior, but had not found a solution.
Thank you so much for this.
It will go into the upcoming release.
…On Thu, Jun 4, 2020 at 3:38 PM Alex Vear ***@***.***> wrote:
While experimenting with the .NET Core port of ClojureCLR, I noticed that
on Linux (and likely also macOS), the REPL was unable to handle backspacing
or the use of the cursor/arrow keys (making typo correction impossible).
After much experimentation, I found that the issue was with the
implementation of *in* and the handling of standard input.
(I also updated the other two "standard streams
<https://en.wikipedia.org/wiki/Standard_streams>" so that they all work
the same way.)
I have tested this patch on .NET Core 3.1 on both Fedora Linux and
Microsoft Windows 10. According to the Microsoft Docs
<https://docs.microsoft.com/en-us/dotnet/api/system.console.openstandardinput>
these changes will work on all .NET Framework, .NET Standard and .NET Core
versions.
If you would like any changes made to this pull request, I'll be happy to
make them.
P.S. Thanks so much for all your work on this port, I'm really excited for
the official .NET Core release of ClojureCLR (no matter how slow start-up
is).
------------------------------
You can view, comment on, or merge this pull request online at:
#32
Commit Summary
- Fix handling of "standard streams" on Unix-like operating systems
File Changes
- *M* Clojure/Clojure/Lib/RT.cs
<https://github.com/clojure/clojure-clr/pull/32/files#diff-fb1610e41da376828e5b237c78632e2e>
(6)
Patch Links:
- https://github.com/clojure/clojure-clr/pull/32.patch
- https://github.com/clojure/clojure-clr/pull/32.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#32>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAUVZLNEYKDWXPPMDKJV5TRVAA4ZANCNFSM4NS63L6Q>
.
|
Previously the ClojureCLR `*in*` (standard input) stream wouldn't behave correctly on Unix-like operating systems such as macOS and Linux. When used to accept user input, it would incorrectly handle backspacing and the use of the cursor/arrow keys. As ClojureCLR's REPL reads from `*in*` it too was affected by this bug. This bug also prevented the REPL from being able to work with other command line tools such as `rlwrap`. Switching from `Console.In` to `Console.OpenStandardInput` resolved the issue. This commit also updates the other standard streams (standard error and standard output) so that they all work the same way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: I have signed the Clojure contributor license agreement, but I've just realised that the Clojure docs say to create a Jira ticket and upload a patch to it instead of creating a pull request; does ClojureCLR follow the same workflow? I'm happy to do that if you'd prefer.
While experimenting with the .NET Core port of ClojureCLR, I noticed that on Linux (and likely also macOS), the REPL was unable to handle backspacing or the use of the cursor/arrow keys.
Here is a screencast of the bug.
After some experimentation, I found that the issue was with the implementation of
*in*. I managed to fix it by replacingConsole.InwithConsole.OpenStandardInput(). (I also updated the other two "standard streams" so that they all work the same way.)I have tested these changes on both Fedora Linux 32 and Microsoft Windows 10 with .NET Core 3.1. According to the Microsoft Docs I linked above this change will work on all .NET Framework, .NET Standard and .NET Core versions.
(Note: this pull request is set to merge to the
newframeworkbranch, as I believe this is only a bug on .NET Core.)If you would like me to make any changes to this pull request, I'm happy to do them, or if you want to make the changes yourself instead of merging this, that's fine with me too.
P.S. Thanks so much for all your work on this port, I'm really excited for the official .NET Core release of ClojureCLR (no matter how slow start-up has to be).