Remove deleted closure compiler warning options #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These checks are deleted from closure compiler used in latests versions of Clojurescript and lead to `NullPointerException`s if included in projects `:closure-warnings` configuration. https://github.com/google/closure-compiler/wiki/Warnings#warnings-categories
Removed in release August 8, 2021 (v20210808) https://github.com/google/closure-compiler/wiki/Releases#august-8-2021-v20210808
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These checks are deleted from closure compiler used in latests versions of Clojurescript
and lead to
NullPointerExceptions if included in projects:closure-warningsconfiguration.https://github.com/google/closure-compiler/wiki/Warnings#warnings-categories
I have considered to include comment on which version of ClojureScript & Closure Compiler an option was removed but feels like if it would not be worth the effort and complexity.