CLJS-3393: Efficient drop, partition for persistent/algo colls #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi, there are some fixes in Clojure master from the original impl for this stuff, so should probably catch up to those before this is merged |
mfikes
force-pushed
the
cljs-3393
branch
5 times, most recently
from
f86ccac to
a7a8086
Compare
|
Updated patches in https://clojure.atlassian.net/jira/software/c/projects/CLJS/issues/CLJS-3393 with the latest, and this PR currently has CLJS-3393-4.patch applied. This PR also now passes the Coal Mine tests: https://gist.github.com/mfikes/9fbf8db14c0f53e5ca26cbebdd8795d0 |
|
@mfikes nice! Feel free to squash/merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.