Skip to content

CLJS-3392: datafy support for js/Error and ExceptionInfo #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2023
Merged

CLJS-3392: datafy support for js/Error and ExceptionInfo #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/main/cljs/clojure/datafy.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@
(with-meta [(deref r)] (meta r)))

(extend-protocol p/Datafiable
js/Error
(datafy [x] (Throwable->map x))

ExceptionInfo
(datafy [x] (Throwable->map x))

Var
(datafy [r] (datify-ref r))

Expand Down
11 changes: 11 additions & 0 deletions src/test/cljs/clojure/datafy_test.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,14 @@
x (with-meta original {`clojure.core.protocols/datafy (fn [_] datafied)})]
(is (= datafied (d/datafy x)))
(is (= {:clojure.datafy/obj original} (meta (d/datafy x)))))))

(deftest datafy-js-errors-test
(let [x (js/Error. "foo")]
(is (= (Throwable->map x) (d/datafy x))))
;; Ensure we can datafy objects that extend js/Error
(let [x (js/RangeError. "x must be between 1 and 5")]
(is (= (Throwable->map x) (d/datafy x)))))

(deftest datafy-ex-info-test
(let [x (ex-info "foo" {:a 1} (ex-info "bar" {:b 2}))]
(is (= (Throwable->map x) (d/datafy x)))))