Skip to content

CLJS-3381: Invokable JS namespaces used as constructors not hinted properly #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2023
Merged

CLJS-3381: Invokable JS namespaces used as constructors not hinted properly #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52a2c2d
tag invokeable :node / :global nses as 'js
swannodette May 1, 2023
e889faf
add node-module-index to infer-test-helper
swannodette May 1, 2023
4b89edf
add test case
swannodette May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/clojure/cljs/analyzer.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,11 +1220,13 @@
:node {:name (symbol (str current-ns)
(munge-node-lib (resolve-ns-alias env ns)))
:op :js-var
:ns current-ns}
:ns current-ns
:tag 'js}
:global {:name (symbol (str current-ns)
(munge-global-export (resolve-ns-alias env ns)))
:op :js-var
:ns current-ns})))
:ns current-ns
:tag 'js})))

(defn resolve-import
"goog.modules are deterministically assigned to a property of the namespace,
Expand Down
26 changes: 24 additions & 2 deletions src/test/clojure/cljs/externs_infer_tests.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
(is (= 'js/Foo (ana/js-tag '[baz] :ret-tag externs)))))

(defn infer-test-helper
[{:keys [forms externs warnings warn js-dependency-index with-core? opts]}]
[{:keys [forms externs warnings warn js-dependency-index node-module-index with-core? opts]}]
(let [test-cenv (atom
(cond->
(if with-core?
Expand All @@ -60,7 +60,8 @@
{::ana/externs
(externs/externs-map
(closure/load-externs {:externs (or externs [])}))})
js-dependency-index (assoc :js-dependency-index js-dependency-index)))
js-dependency-index (assoc :js-dependency-index js-dependency-index)
node-module-index (assoc :node-module-index node-module-index)))
wrap (if with-core?
#(comp/with-core-cljs nil %)
#(do (%)))]
Expand Down Expand Up @@ -453,6 +454,27 @@
"Object.someProperty;"])
res)))))

(deftest test-cljs-3381
(testing "invokeable js namespaces not hinted properly"
(let [ws (atom [])
res (infer-test-helper
{:node-module-index #{"markdown-it"}
:forms '[(ns foo.core
(:require [markdown-it]))
(defonce mdi
(doto (new markdown-it
(js-obj
"linkify" true
"typographer" true))
(.renderInline mdi "hi")))]
:warnings ws
:warn true
:with-core? false
:target :nodejs})]
(is (= (unsplit-lines
["Object.renderInline;"])
res)))))

(comment
(binding [ana/*cljs-ns* ana/*cljs-ns*]
(ana/no-warn
Expand Down