Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Configure travis.ci to run integration tests #21

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants

Gozala commented Jan 5, 2013

I have being using travis.ci with bunch of other projects and it's being great to be able too see status of test run in the pull requests regardless of weather you submit a change or do a review. It would be really useful to have this for clojurescript too.

Tests do work on my fork right now:
https://travis-ci.org/Gozala/clojurescript

In addition to pulling this change github hook needs to be enabled (before the pull) to trigger tests runs on pull requests and pushes. Details on this can be found here:

http://about.travis-ci.org/docs/user/how-to-setup-and-trigger-the-hook-manually/

@Gozala Gozala referenced this pull request in kanaka/clojurescript Jan 6, 2013

Merged

Configure travis.ci integration tests. #2

ldenman commented Jan 17, 2013

Cool idea, I like it! +1

Member

swannodette commented Jan 18, 2013

As with all official Clojure projects - ClojureScript does not accept pull requests. Please submit tickets and patches to JIRA. It's also nice to post to the clojure-dev list to make sure there's actually interest in something like this first. Thanks!

Gozala commented Jan 18, 2013

If clojurescript doesn't take pull requests this is pointless, since whole purpose of it to displays weather submitted pull request passes or fails them.

P.S.: Patch for any pull request is just addition of .patch to the url see:
https://github.com/clojure/clojurescript/pull/21.patch

@Gozala is absolutely right.

Also, JIRA has git support and git is designed for distributed source control management—it's trivial to accept changes via pull request, merge them to your local clone and push back to the JIRA master and github.

You can also integrate post-commit hooks in here to hit tickets in JIRA. See: https://confluence.atlassian.com/display/JIRASTUDIO/Linking+GitHub+Activities+to+JIRA+Issues

I'm sure you could modify a pull-request hook to create a ticket in JIRA and then link the .patch of the pull request. Maybe someone could do that work the project? I think you'd get more involvement, which is always good! Travis CI is a really great thing to have to help maintain quality in the patches that other devs are sending in.

Member

swannodette commented Jan 18, 2013

Any process to improve workflow would be great. But I will say patches involve running quite a few sanity checks including manually checking that the both the Rhino REPL & the Browser REPL are not broken and that there are no serious performance regressions. It's perhaps possible to automate these as well, but no one has stepped forward with the initial work. When those things are covered then I think something like Travis CI would be considerably more compelling / useful.

Any takers? :)

Gozala commented Jan 18, 2013

I was planning on getting to that too, but had to start somewhere. This felt like a good entry point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment