Skip to content

runtime existence check for :require-global libs #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2025
+16 −11
Merged

runtime existence check for :require-global libs #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions src/main/clojure/cljs/compiler.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1312,19 +1312,24 @@
(apply str
(map #(str "['" % "']") xs)))))

(defn emit-global-export [ns-name global-exports lib]
(let [[lib' sublib] (ana/lib&sublib lib)]
(defn emit-global-export [ns-name global-exports lib opts]
(let [[lib' sublib] (ana/lib&sublib lib)
ref (str "goog.global"
;; Convert object dot access to bracket access
(->> (string/split (name (or (get global-exports (symbol lib'))
(get global-exports (name lib'))))
#"\.")
(map (fn [prop] (str "[\"" prop "\"]")))
(apply str)))]
(when (and (ana/external-dep? lib')
(= :none (:optimizations opts)))
(emitln
"if(!" ref ") throw new Error(\"External library, " lib' ", never provided\");"))
(emitln
(munge ns-name) "."
(ana/munge-global-export lib)
" = goog.global"
;; Convert object dot access to bracket access
(->> (string/split (name (or (get global-exports (symbol lib'))
(get global-exports (name lib'))))
#"\.")
(map (fn [prop]
(str "[\"" prop "\"]")))
(apply str))
" = "
ref
(sublib-select sublib)
";")))

Expand Down Expand Up @@ -1409,7 +1414,7 @@
;; Global Exports
(doseq [lib global-exports-libs]
(let [{:keys [global-exports]} (get js-dependency-index (name (-> lib ana/lib&sublib first)))]
(emit-global-export ns-name global-exports lib)))
(emit-global-export ns-name global-exports lib options)))
(when (-> libs meta :reload-all)
(emitln "if(!COMPILED) " loaded-libs " = cljs.core.into(" loaded-libs-temp ", " loaded-libs ");"))))

Expand Down