Support (try (catch :default)) in CLJS exception handling #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump CLJS version to one that supports :default. This should be backwards compatible with the old version, but the tests don't run without bumping the dependency.
|
This is a great patch, but we cannot merge a pull request. Please submit a patch to JIRA thanks! |
|
yep, noticed that in the contributing guide, sorry about that - patches are attached to all three tickets I filed this week end - lemme know if you need anything else! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump CLJS version to one that supports :default. This should be
backwards compatible with the old version, but the tests don't run
without bumping the dependency.