Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build manylinux wheels #96

Closed
wants to merge 5 commits into from
Closed

Build manylinux wheels #96

wants to merge 5 commits into from

Conversation

movermeyer
Copy link
Collaborator

@movermeyer movermeyer commented Oct 24, 2020

Use manylinux to build wheels for all the major linux distributions, for both x86_64 and i686 architectures.

First step towards #25


@thomasst: Check it out! 😁

Create the release artifacts

Send a POST request to the CircleCI API to trigger the build_wheels workflow.

Substitute $CIRCLE_TOKEN with your personal API token:

curl --location --request POST 'https://circleci.com/api/v2/project/gh/closeio/ciso8601/pipeline' \
--header 'Circle-Token: $CIRCLE_TOKEN' \
--header 'Content-Type: application/json' \
--data-raw '{
  "branch": "mo.build_wheels",
  "parameters": {
    "build_wheels": true
  }
}'

@movermeyer movermeyer force-pushed the mo.build_wheels branch 6 times, most recently from c9217dc to a1fee18 Compare October 25, 2020 20:09
@movermeyer movermeyer marked this pull request as ready for review October 25, 2020 20:10
@movermeyer movermeyer changed the title Build wheels Build manylinux wheels Oct 25, 2020
RELEASING.md Outdated Show resolved Hide resolved
Substitute `$CIRCLE_TOKEN` with your [personal API token](https://app.circleci.com/settings/user/tokens):

```bash
curl --location --request POST 'https://circleci.com/api/v2/project/gh/closeio/ciso8601/pipeline' \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having to do this manually, could we use a commit tag, e.g. specifying the string #buildwheels in the commit message would trigger the wheels?

Copy link
Collaborator Author

@movermeyer movermeyer Nov 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

We should sort out the release process.

@movermeyer movermeyer marked this pull request as draft November 1, 2020 18:10
@movermeyer movermeyer marked this pull request as ready for review November 1, 2020 18:13
@movermeyer movermeyer marked this pull request as draft November 1, 2020 18:13
@movermeyer
Copy link
Collaborator Author

movermeyer commented Nov 1, 2020

We should not merge this until we have confirmed that the pre-built wheels are not super slow relative to the "compiled from the sdist" ones.

If there is a discrepancy, we should include instructions in the README for how to force pip to use the source distribution instead of the pre-built wheels.

@movermeyer
Copy link
Collaborator Author

Closing in favour of #97

@movermeyer movermeyer closed this Oct 18, 2021
@movermeyer movermeyer deleted the mo.build_wheels branch December 21, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants