devices: Add pvpanic support #5526

up2wing · 2023-06-20T08:24:26Z

When crash occurs in guest, we can use pvpanic device to notify through the event-monitor. This is useful to monitor the guest's running state and respond to the event.

The pvpanic device can be implemented as an ISA device or PCI device, we implemented the pvpanic-pci device for now.

vmm/src/device_manager.rs

up2wing · 2023-06-22T04:49:49Z

Hi Rob,
Could you please review this patch again? I update it as you suggested :)

@rbradford

rbradford · 2023-06-26T13:34:40Z

vmm/src/config.rs

+        parser.add_valueless("pci");
+        parser.parse(device_type).map_err(Error::ParsePvPanic)?;
+
+        if parser.is_set("pci") {


I don't think we will ever support anything other than a PCI device so you don't need this.

rbradford · 2023-06-28T09:11:27Z

I think you need to update the integration tests.

up2wing · 2023-06-28T09:42:28Z

I think you need to update the integration tests.

Yes, I am working on this.
Thanks a lot :)

up2wing · 2023-06-29T08:09:42Z

I think you need to update the integration tests.

patches have been updated, Rob ;)
@rbradford

rbradford · 2023-06-30T08:49:54Z

tests/integration.rs

+            // Wait a while for guest
+            thread::sleep(std::time::Duration::new(5, 0));
+
+            // Ignore event check tempraly, as we need pvpanic-pci driver


Why not add the panic driver to the kernel config file?

Do you mean resources/linux-config-x86_64?
Will the vmlinux used in CI workloads build from this config? Forgive me for not knowing this 😅

Yes, the CI builds from that config file - there is an aarch64 equivalent too.

Okay. I will try to fix this.
Thx 😸

rbradford

Looking good - really close now!

rbradford · 2023-07-03T10:50:22Z

vmm/src/config.rs

+    /// Failed parsing pvpanic
+    ParsePvPanic(OptionParserError),
+    /// No device type given for pvpanic
+    ParsePvPanicDeviceTypeGiven,


Leftover error

Oh yes, thanks to point out.

rbradford · 2023-07-03T10:50:35Z

vmm/src/config.rs

@@ -336,6 +340,13 @@ impl fmt::Display for Error {
            ParseVdpaPathMissing => write!(f, "Error parsing --vdpa: path missing"),
            ParseTpm(o) => write!(f, "Error parsing --tpm: {o}"),
            ParseTpmPathMissing => write!(f, "Error parsing --tpm: path missing"),
+            ParsePvPanic(o) => write!(f, "Error parsing --pvpanic: {}", o),
+            ParsePvPanicDeviceTypeGiven => {


This can also be removed.

rbradford · 2023-07-03T10:51:02Z

resources/linux-config-aarch64

@@ -1402,7 +1402,9 @@ CONFIG_NVME_MULTIPATH=y
 # CONFIG_MISC_RTSX_PCI is not set
 # CONFIG_HABANA_AI is not set
 # CONFIG_UACCE is not set
-# CONFIG_PVPANIC is not set
+CONFIG_PVPANIC=y
+CONFIG_PVPANIC_MMIO=y


Do you need this one? Does PCI depend on it?

No :)
We need pvpanic-pci only now, I will fix that immediately.

up2wing · 2023-07-05T00:26:06Z

Hi all,
There are still three build check fail which I am not sure where's the problem. I revert the source code to that before I push the pvpanic patch, the problems still exist :(

likebreath · 2023-07-05T17:51:50Z

Hi all, There are still three build check fail which I am not sure where's the problem. I revert the source code to that before I push the pvpanic patch, the problems still exist :(

Please rebase. I believe the issues have been fixed in the upstream main branch with #5566 and #5567.

up2wing · 2023-07-06T01:10:26Z

Hi all, There are still three build check fail which I am not sure where's the problem. I revert the source code to that before I push the pvpanic patch, the problems still exist :(

Please rebase. I believe the issues have been fixed in the upstream main branch with #5566 and #5567.

That works, thanks so much.
I will pay attention to this in the future.

rbradford · 2023-07-06T07:49:44Z

vmm/src/device_manager.rs

+
+        self.device_tree.lock().unwrap().insert(id, node);
+
+        info!("add pvpanic device");


Please remove this log.

Introduce emulation of pvpanic device to allow cloud hypervisor to get the notify from guest's pvpanic driver when guest kernel crash. Signed-off-by: Yi Wang <foxywang@tencent.com>

Implemetion of BusDevice and PciDevice trait for pvpanic device. Pvpanic device can be implemented as an ISA device or as a PCI device, we choose PCI device for now. Signed-off-by: Yi Wang <foxywang@tencent.com>

Add PvPanicDeviceState to retore events of pvpanic from snapshot, and also PciConfigurationState. Signed-off-by: Yi Wang <foxywang@tencent.com>

Add method for DeviceManager to invoke. Signed-off-by: Yi Wang <foxywang@tencent.com> Signed-off-by: Rob Bradford <rbradford@rivosinc.com>

Add integration test for pvpanic, by two methods: - the vendor id and device id of pci device in guest - triggering a guest panic and check event-monitor. Also, to support pvpanic-pci driver, add pvpanic config in resources. Signed-off-by: Yi Wang <foxywang@tencent.com> Signed-off-by: Rob Bradford <rbradford@rivosinc.com>

up2wing requested a review from a team as a code owner June 20, 2023 08:24

up2wing force-pushed the pvpanic branch 2 times, most recently from d4d35e7 to 1b7e1de Compare June 20, 2023 14:22

rbradford reviewed Jun 20, 2023

View reviewed changes

vmm/src/device_manager.rs Outdated Show resolved Hide resolved

up2wing force-pushed the pvpanic branch from 1b7e1de to 994eb04 Compare June 21, 2023 10:04

rbradford reviewed Jun 26, 2023

View reviewed changes

up2wing force-pushed the pvpanic branch 4 times, most recently from bacc9cf to 7394466 Compare June 28, 2023 04:03

up2wing force-pushed the pvpanic branch from 7394466 to 4d8b4eb Compare June 28, 2023 09:41

up2wing force-pushed the pvpanic branch from 4d8b4eb to 826d76a Compare June 29, 2023 06:20

rbradford reviewed Jun 30, 2023

View reviewed changes

up2wing force-pushed the pvpanic branch 2 times, most recently from a8c4b05 to d5fcc3c Compare July 3, 2023 07:14

rbradford reviewed Jul 3, 2023

View reviewed changes

up2wing force-pushed the pvpanic branch from d5fcc3c to cc1e58b Compare July 3, 2023 11:18

up2wing force-pushed the pvpanic branch from cc1e58b to 98839e5 Compare July 5, 2023 23:47

rbradford approved these changes Jul 6, 2023

View reviewed changes

up2wing added 4 commits July 6, 2023 16:04

devices: Add support for pvpanic device

391e557

Introduce emulation of pvpanic device to allow cloud hypervisor to get the notify from guest's pvpanic driver when guest kernel crash. Signed-off-by: Yi Wang <foxywang@tencent.com>

devices: pvpanic: Add pci configuration for pvpanic device

0f27b14

Implemetion of BusDevice and PciDevice trait for pvpanic device. Pvpanic device can be implemented as an ISA device or as a PCI device, we choose PCI device for now. Signed-off-by: Yi Wang <foxywang@tencent.com>

devices: pvpanic: add snapshot support

84a75d0

Add PvPanicDeviceState to retore events of pvpanic from snapshot, and also PciConfigurationState. Signed-off-by: Yi Wang <foxywang@tencent.com>

devices: pvpanic: add method for DeviceManager

b06de7a

Add method for DeviceManager to invoke. Signed-off-by: Yi Wang <foxywang@tencent.com> Signed-off-by: Rob Bradford <rbradford@rivosinc.com>

up2wing force-pushed the pvpanic branch from 98839e5 to e93e288 Compare July 6, 2023 08:04

rbradford merged commit 9935385 into cloud-hypervisor:main Jul 6, 2023
22 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

devices: Add pvpanic support #5526

devices: Add pvpanic support #5526

up2wing commented Jun 20, 2023

up2wing commented Jun 22, 2023

rbradford Jun 26, 2023

rbradford commented Jun 28, 2023

up2wing commented Jun 28, 2023

up2wing commented Jun 29, 2023

rbradford Jun 30, 2023

up2wing Jun 30, 2023

rbradford Jun 30, 2023

up2wing Jun 30, 2023

rbradford left a comment

rbradford Jul 3, 2023

up2wing Jul 3, 2023

rbradford Jul 3, 2023

rbradford Jul 3, 2023

up2wing Jul 3, 2023

up2wing commented Jul 5, 2023

likebreath commented Jul 5, 2023

up2wing commented Jul 6, 2023

rbradford Jul 6, 2023

up2wing Jul 6, 2023


		self.device_tree.lock().unwrap().insert(id, node);

		info!("add pvpanic device");

devices: Add pvpanic support #5526

devices: Add pvpanic support #5526

Conversation

up2wing commented Jun 20, 2023

up2wing commented Jun 22, 2023

Choose a reason for hiding this comment

rbradford commented Jun 28, 2023

up2wing commented Jun 28, 2023

up2wing commented Jun 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rbradford left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

up2wing commented Jul 5, 2023

likebreath commented Jul 5, 2023

up2wing commented Jul 6, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment