Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Bump zbus from 3.15.2 to 4.1.2 #6400

Merged
merged 1 commit into from
May 22, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 18, 2024

Bumps zbus from 3.15.2 to 4.1.2.

Release notes

Sourced from zbus's releases.

🔖 zbus 4.1.2

To go with zbus_macros 4.1.2. Other changes:

  • ⬆️ Bump nix to 0.28.

🔖 zbus_macros 4.1.2

  • ⏪️ Revert unpinnig of zvariant_utils version in Cargo.toml. The reverted change ended up bumping our MSRV to 1.75 in 3.x series. We don't want that.

🔖 zbus 4.1.1

The actual change is in zbus_macros 4.1.1.

🔖 zbus_macros 4.1.1

  • 📌 Unpin zvariant_utils version in Cargo.toml files. #652.

🔖 zbus 4.1.0

  • 🚑️ zb: Fix a deprecation re-export.
  • 🔥 zb: Remove some redundant imports.
  • ✏️ zb: Fix a typo in docs.
  • ⬆️ Updated deps:
    • async-io to v2.3.1.
    • async-process to 2.1.0.
    • async-task to 4.7.0.
    • async-recursion to 1.0.5.
    • async-lock to 3.3.0.
    • async-fs to 2.1.1.
    • async-executor to 1.8.0.
    • async-trait to 0.1.77.
    • blocking to 1.5.1.
    • enumflags2 to 0.7.9.
    • event-listener to 5.1.0.
    • futures-sink to 0.3.30.
    • futures-core to 0.3.30.
    • futures-util to 0.3.30.
    • sha1 to 0.10.6.
    • serde_repr to 0.1.18.
    • tracing to 0.1.40.
    • tempfile to 3.10.0.
    • xdg-home to 1.1.0.

🔖 zbus_macros 4.1.0

To go with zbus 4.1.0.

  • 🔥 Remove redundant imports.
  • ⬆️ Updated deps:
    • proc-macro-crate to v3.
    • syn to 1.0.109.

... (truncated)

Commits
  • 55d9646 Merge pull request #658 from zeenix/rel-4.1.2
  • 8bcc6aa 🔖 zb,zm: Release 4.1.2
  • 85efd58 🔖 zv,zd: Release 4.0.2
  • 84aa0e5 ⏪️ Revert "📌 zm,zd: Unpin zvariant_utils version in Cargo.toml files"
  • e0a6344 Merge pull request #657 from zeenix/upgrade-nix-0.28
  • ffd0136 ⬆️ zb: Bump nix to 0.28
  • 55b8b18 Merge pull request #655 from zeenix/zb-4.1.1
  • 75234a3 🔖 zb,zm: Release 4.1.1
  • 0ce1cb7 Merge pull request #654 from zeenix/zv-4.0.1
  • 261f69e 🔖 zv,zd: Release 4.0.1
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @cloud-hypervisor-bot.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner April 18, 2024 23:59
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 18, 2024
Copy link

@cloud-hypervisor-bot cloud-hypervisor-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beep boop! I am also a 🤖 - let's join forces!

@dependabot merge

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 19, 2024

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@rbradford
Copy link
Member

@brkp Are you still using the d-bus integration? Can you look into this?

@dependabot dependabot bot force-pushed the dependabot/cargo/zbus-4.1.2 branch 2 times, most recently from 6a78cc0 to c1f70cf Compare April 25, 2024 21:46
@rbradford rbradford closed this Apr 26, 2024
auto-merge was automatically disabled April 26, 2024 07:52

Pull request was closed

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 26, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/zbus-4.1.2 branch April 26, 2024 07:52
@nullptropy
Copy link
Contributor

Hey @rbradford, sorry for the delay. I was off-site for the entire week and completely forgot to go through this.

Bumping zbus requires the MSRV to be bumped to 1.75. But the new version of zbus doesn't really justify changing the MSRV IMHO, as it includes no security or important bug fixes. We could migrate to the new version when there's a more pressing reason to make the MSRV switch, if you also agree.

As for our use of zbus, I am still involved as an independent contractor, mainly responsible for maintaining the feature and implementing necessary improvements when needed. So yes, I'm still very much involved with the project. Please do make me aware of anything that needs work with regard to the D-Bus integration!

@rbradford
Copy link
Member

Hey @rbradford, sorry for the delay. I was off-site for the entire week and completely forgot to go through this.

Bumping zbus requires the MSRV to be bumped to 1.75. But the new version of zbus doesn't really justify changing the MSRV IMHO, as it includes no security or important bug fixes. We could migrate to the new version when there's a more pressing reason to make the MSRV switch, if you also agree.

As for our use of zbus, I am still involved as an independent contractor, mainly responsible for maintaining the feature and implementing necessary improvements when needed. So yes, I'm still very much involved with the project. Please do make me aware of anything that needs work with regard to the D-Bus integration!

It's fine to bump MSRV for dependencies - in fact that is the main reason for us to do so.

@rbradford
Copy link
Member

@dependabot reopen
@dependabot rebase

The MSRV has been bumped recently.

Copy link
Contributor Author

dependabot bot commented on behalf of github May 22, 2024

Looks like this PR is closed. If you re-open it, I'll rebase it, as long as no-one else has edited it.

@dependabot dependabot bot reopened this May 22, 2024
@dependabot dependabot bot restored the dependabot/cargo/zbus-4.1.2 branch May 22, 2024 15:07
Copy link

@cloud-hypervisor-bot cloud-hypervisor-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beep boop! I am also a 🤖 - let's join forces!

@dependabot merge

Bumps [zbus](https://github.com/dbus2/zbus) from 3.15.2 to 4.1.2.
- [Release notes](https://github.com/dbus2/zbus/releases)
- [Commits](dbus2/zbus@zbus-3.15.2...zbus-4.1.2)

---
updated-dependencies:
- dependency-name: zbus
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/zbus-4.1.2 branch from c1f70cf to c2dd4fa Compare May 22, 2024 15:08
@nullptropy
Copy link
Contributor

We have some deprecation warnings with the new version, I'll update the implementation once this PR is merged:

warning: use of deprecated macro `dbus_interface`: Use `#[interface(...)]` proc macro with `#[zbus(...)]` item attributes instead.
   --> vmm/src/api/dbus/mod.rs:108:3
    |
108 | #[dbus_interface(name = "org.cloudhypervisor.DBusApi1")]
    |   ^^^^^^^^^^^^^^
    |
    = note: `#[warn(deprecated)]` on by default

warning: `vmm` (lib) generated 1 warning
warning: use of deprecated macro `dbus_proxy`: Use `#[proxy(...)]` proc macro with `#[zbus(...)]` item attributes instead.
  --> src/bin/ch-remote.rs:75:3
   |
75 | #[dbus_proxy(name = "org.cloudhypervisor.DBusApi1", assume_defaults = false)]
   |   ^^^^^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default

@cloud-hypervisor-bot cloud-hypervisor-bot added this pull request to the merge queue May 22, 2024
@rbradford
Copy link
Member

We have some deprecation warnings with the new version, I'll update the implementation once this PR is merged:

Thank you!

Merged via the queue into main with commit eb8f959 May 22, 2024
36 checks passed
@dependabot dependabot bot deleted the dependabot/cargo/zbus-4.1.2 branch May 22, 2024 16:38
nullptropy added a commit to sartura/cloud-hypervisor that referenced this pull request May 22, 2024
Fixes deprecation related warnings introduced in cloud-hypervisor#6400.

Signed-off-by: Omer Faruk Bayram <omer.faruk@sartura.hr>
nullptropy added a commit to sartura/cloud-hypervisor that referenced this pull request May 22, 2024
Fixes deprecation related warnings introduced in cloud-hypervisor#6400.

Signed-off-by: Omer Faruk Bayram <omer.faruk@sartura.hr>
github-merge-queue bot pushed a commit that referenced this pull request May 23, 2024
Fixes deprecation related warnings introduced in #6400.

Signed-off-by: Omer Faruk Bayram <omer.faruk@sartura.hr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants