Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI implementation draft (AppAPI 1.4+)(Part1) #168

Merged
merged 13 commits into from
Dec 3, 2023
Merged

UI implementation draft (AppAPI 1.4+)(Part1) #168

merged 13 commits into from
Dec 3, 2023

Conversation

bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Nov 29, 2023

Reference: nextcloud/app_api#135

First part.

  • Added API for UI, Example(not finished yet).

Missing:

  • Example and description how to use it in docs, and example in example folder is not fully finished.

bigcat88 and others added 9 commits November 29, 2023 14:29
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #168 (d233d01) into main (d229b43) will decrease coverage by 0.14%.
The diff coverage is 97.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   99.77%   99.63%   -0.14%     
==========================================
  Files          34       36       +2     
  Lines        3134     3331     +197     
==========================================
+ Hits         3127     3319     +192     
- Misses          7       12       +5     
Files Coverage Δ
nc_py_api/ex_app/__init__.py 100.00% <100.00%> (ø)
nc_py_api/ex_app/ui/resources.py 100.00% <100.00%> (ø)
nc_py_api/ex_app/ui/ui.py 100.00% <100.00%> (ø)
nc_py_api/ex_app/integration_fastapi.py 98.52% <83.33%> (-1.48%) ⬇️
nc_py_api/ex_app/ui/files_actions.py 98.09% <94.73%> (ø)
nc_py_api/ex_app/ui/top_menu.py 95.74% <95.74%> (ø)

bigcat88 and others added 4 commits November 30, 2023 11:48
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88 bigcat88 changed the title UI implementation draft (AppAPI 1.4+) UI implementation draft (AppAPI 1.4+)(Part1) Dec 3, 2023
@bigcat88
Copy link
Contributor Author

bigcat88 commented Dec 3, 2023

This will be merged, there will be a second part where the example will be completed, the documentation will be updated and then there will be a release.

Errors related to AppAPI, need first fix them there and after that continue work on polishing this.

@bigcat88 bigcat88 marked this pull request as ready for review December 3, 2023 14:55
@bigcat88 bigcat88 merged commit 2dbc82c into main Dec 3, 2023
17 of 18 checks passed
@bigcat88 bigcat88 deleted the ExApp-UI branch December 3, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants