Skip to content

fixed bug when options.NPA_NC_CERT=False #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Conversation

bigcat88
Copy link
Member

Was incorrect handling, as values in environment variables are strings.

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #93 (932c5d0) into main (36522d1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files          26       26           
  Lines        1755     1761    +6     
=======================================
+ Hits         1748     1754    +6     
  Misses          7        7           
Files Changed Coverage Δ
nc_py_api/options.py 100.00% <100.00%> (ø)

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88 bigcat88 merged commit a9c2e30 into main Aug 21, 2023
@bigcat88 bigcat88 deleted the options-NPA_NC_CERT-fix branch August 21, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant