This repository was archived by the owner on Aug 30, 2024. It is now read-only.
Move session, login and logout methods from Resource to Account #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That makes sense. I used the big green button on another PR so I'll merge this manually. Thanks! |
|
Reopen sesame! |
It's a bit awkward to have the code:
db = cloudant.Database(url)
doc = db.document(docid)
doc.login('username', 'password')
Since these methods are not related to document nor database resources.
Account as holder of server root endpoint method is more suitable place
for them.
garbados
added a commit
that referenced
this pull request
Mar 24, 2014
Move session, login and logout methods from Resource to Account
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit awkward to have the code:
db = cloudant.Database(url)
doc = db.document(docid)
doc.login('username', 'password')
Since these methods are not related to document nor database resources.
Account as holder of server root endpoint method is more suitable place
for them.