Skip to content

Conversation

Hairash
Copy link
Member

@Hairash Hairash commented Dec 15, 2022

  • Add isort library and settings
  • Remove flake8-import-order
  • Run isort
  • Fix build.yml
  • Add isort run information to the README.md

@maxipavlovic maxipavlovic self-requested a review December 16, 2022 10:30
maxipavlovic
maxipavlovic previously approved these changes Dec 16, 2022
@Hairash Hairash force-pushed the LITE-25845-add-isort branch 2 times, most recently from c7d2e7f to b6ac030 Compare December 16, 2022 11:49
@Hairash Hairash changed the title LITE-25845 Add isort [X] LITE-25845 Add isort Dec 16, 2022
@Hairash Hairash force-pushed the LITE-25845-add-isort branch from b6ac030 to 5a0a935 Compare December 16, 2022 13:07
@Hairash Hairash changed the title [X] LITE-25845 Add isort LITE-25845 Add isort Dec 16, 2022
@qarlosh
Copy link
Contributor

qarlosh commented Dec 16, 2022

Maybe some note in README/Development about running isort would be nice.

@Hairash Hairash force-pushed the LITE-25845-add-isort branch from 5a0a935 to da6afa7 Compare December 16, 2022 13:53
ffaraone
ffaraone previously approved these changes Dec 16, 2022
* Add isort library and settings
* Remove flake8-import-order
* Run isort
* Fix build.yml
* Add isort run information to the README.md
@maxipavlovic maxipavlovic merged commit d88911f into master Dec 19, 2022
@Hairash Hairash deleted the LITE-25845-add-isort branch December 19, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants