Add the ability to specify custom role config groups for sets of hosts #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tristan Stevens <tristan@cloudera.com>
Signed-off-by: Tristan Stevens <tristan@cloudera.com>
|
LGTM. We will need to make a few additional changes for teardown to work with custom role groups, but it will continue to work for non-custom role groups. As this devel, I'm happy for this to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to specify custom role config groups by using the syntax ROLETYPE/CUSTOMROLENAME as follows:
Includes logic to fold in any default values from the config overlays (TLS, Kerberos, etc) and to inherit any base configs specified (for example
scratch_dirsabove).Tested on a cluster with and without custom rcgs.