Show loader for doc summaries and open response links in new tab #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a spinner icon during document summary loading and ensures external links open in a new tab.
- Opens MarkdownResponse links in a new browser tab.
- Imports
Spinand displays a spinner while fetching summaries. - Keeps existing documentation icon for completed loads.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ui/src/pages/RagChatTab/ChatOutput/ChatMessages/MarkdownResponse.tsx | Added target="_blank" to anchor tags |
| ui/src/pages/DataSources/ManageTab/SummaryColumn.tsx | Imported Spin and conditionally shows loading icon |
Comments suppressed due to low confidence (1)
ui/src/pages/DataSources/ManageTab/SummaryColumn.tsx:79
- Consider adding a unit or integration test to verify that the spinner renders when documentSummary.isLoading is true.
{documentSummary.isLoading ? (
ui/src/pages/RagChatTab/ChatOutput/ChatMessages/MarkdownResponse.tsx
Outdated
Show resolved
Hide resolved
ewilliams-cloudera
changed the title
…se.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
baasitsharief
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.