-
Notifications
You must be signed in to change notification settings - Fork 11
Implement fake-streaming for non-streaming tool models #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ae0d1ec
to
d34b520
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Implements fake streaming for non-streaming Bedrock tool-calling models and updates scripts/CI to use prebuilt artifacts.
- Redirects startup/download scripts to
prebuilt_artifacts
instead of dynamic downloads. - Introduces
FakeStreamBedrockConverse
wrapper and conditional logic in the tool-calling agent. - Adjusts GitHub Actions to install Git LFS and populate the
prebuilt_artifacts
folder.
Reviewed Changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
scripts/startup_java.sh | Switched jar path from artifacts to prebuilt_artifacts |
scripts/refresh_project.sh | Disabled downloads, switched extracts to prebuilt_artifacts |
scripts/release_version.txt | Changed default RELEASE_TAG to dev-testing |
.github/workflows/publish_release.yml | Added Git LFS steps and copied build outputs into prebuilt_artifacts |
.gitattributes | Configured LFS for prebuilt_artifacts/* |
llm-service/app/services/query/querier.py | Added get_model_name , modified model support check for Bedrock models |
llm-service/app/services/query/agents/tool_calling_querier.py | New fake-stream branching and updated prompt date/time formatting |
llm-service/app/services/query/agents/non_streamer_bedrock_converse.py | Introduced FakeStreamBedrockConverse class |
Comments suppressed due to low confidence (2)
llm-service/app/services/query/agents/non_streamer_bedrock_converse.py:18
- You've added a new
FakeStreamBedrockConverse
class but no tests. Adding unit tests to verify thatastream_chat_with_tools
yields exactly oneChatResponse
would help prevent regressions.
class FakeStreamBedrockConverse(BedrockConverse):
llm-service/app/services/query/querier.py:142
- You compare
get_model_name(model_name)
againstMODIFIED_BEDROCK_FUNCTION_CALLING_MODELS
(which is based on raw model names). Ifget_model_name
normalizes differently, this check may never pass. Ensure both use the same normalized key.
return get_model_name(model_name) in MODIFIED_BEDROCK_FUNCTION_CALLING_MODELS
2af2941
to
f97e1e0
Compare
llm-service/app/services/query/agents/non_streamer_bedrock_converse.py
Outdated
Show resolved
Hide resolved
llm-service/app/services/query/agents/non_streamer_bedrock_converse.py
Outdated
Show resolved
Hide resolved
Co-authored-by: mliu-cloudera <mliu@cloudera.com>
No description provided.