Skip to content

Commit e3dd9c6

Browse files
committed
added type = 'view' for views
1 parent 75fde49 commit e3dd9c6

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

desktop/libs/notebook/src/notebook/connectors/sql_alchemy.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,9 +438,12 @@ def autocomplete(self, snippet, database=None, table=None, column=None, nested=N
438438
response['databases'] = [db or '' for db in assist.get_databases()]
439439
elif table is None:
440440
tables_meta = []
441-
for t in assist.get_tables(database):
441+
for t in assist.get_table_names(database):
442442
t = self._fix_bigquery_db_prefixes(t)
443443
tables_meta.append({'name': t, 'type': 'Table', 'comment': ''})
444+
for t in assist.get_view_names(database):
445+
t = self._fix_bigquery_db_prefixes(t)
446+
tables_meta.append({'name': t, 'type': 'View', 'comment': ''})
444447
response['tables_meta'] = tables_meta
445448
elif column is None:
446449
columns = assist.get_columns(database, table)

desktop/libs/notebook/src/notebook/connectors/sql_alchemy_tests.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,8 @@ def test_get_tables(self):
287287
response = SqlAlchemyApi(self.user, self.interpreter).autocomplete(snippet, database='database1')
288288
assert_equal(response['tables_meta'][0]['name'], 'table1')
289289
assert_equal(response['tables_meta'][1]['name'], 'view1')
290+
assert_equal(response['tables_meta'][0]['type'], 'Table')
291+
assert_equal(response['tables_meta'][1]['type'], 'View')
290292

291293

292294
def test_get_sample_data_table(self):

0 commit comments

Comments
 (0)