[security][knox] include hue_lb in the list of allowed hosts #3403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For knox authentication, the host from header HTTP_X_FORWARDED_HOST is matched against the list of the knox gateways/hosts. But, when a request is passing through a hue_lb then the header contains the hostname of the LB and in such cases, the auth was failing. This commit includes the hue_lb's in the the list to be matched with the FORWARDED_HOST values in the header. Tested on cloudcat cluster with knox and HUE LB Change-Id: I66bcbc74ecdf2ba7e623a41e345158da641a4ffd
amitsrivastava
requested review from
wing2fly,
quadoss,
ranade1,
athithyaaselvam and
Harshg999
wing2fly
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For knox authentication, the host from header HTTP_X_FORWARDED_HOST is matched against the list of the knox gateways/hosts. But, when a request is passing through a hue_lb then the header contains the hostname of the LB and in such cases, the auth was failing.
This commit includes the hue_lb's in the the list to be matched with the FORWARDED_HOST values in the header.
Tested on cloudcat cluster with knox and HUE LB
Change-Id: I66bcbc74ecdf2ba7e623a41e345158da641a4ffd